Last modified: 2011-02-14 00:33:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27675, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25675 - API opensearch cannot find special page with spaces (does not convert underscores in aliases)
API opensearch cannot find special page with spaces (does not convert undersc...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Roan Kattouw
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-27 19:16 UTC by Umherirrender
Modified: 2011-02-14 00:33 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
normalize the search key (548 bytes, patch)
2010-10-28 20:54 UTC, Umherirrender
Details

Description Umherirrender 2010-10-27 19:16:02 UTC
Special page with spaces cannot find by mwsuggest when have the space inside the search term.

For example. Search for "Spezial:Vorlagen expandieren" (Special:ExpandTemplates) on de.wp. After typing "Spezial:Vorlagen e" the scrolldown box is missing.

The problem is, that PrefixIndex::specialSearch get the title without underscores, but the alias is stored with underscore.

Thanks.

Am not sure, which is the best component, so use "General" for now.
Comment 1 Umherirrender 2010-10-27 19:30:49 UTC
(In reply to comment #0)
> The problem is, that PrefixIndex::specialSearch get the title without

It is "PrefixSearch::specialSearch"
Comment 2 Umherirrender 2010-10-28 20:54:48 UTC
Created attachment 7763 [details]
normalize the search key

The patch normalized the space to underscore, so the alias can be found.

This works, because LocalisationCache also replace spaces to underscore inside aliases.
Comment 3 Umherirrender 2010-10-29 21:56:13 UTC
Please have also a look at bug 25713. Thanks.
Comment 4 Krinkle 2011-02-14 00:31:50 UTC
mwsuggest.js is the script used before 1.17 to do autocompletion and suggestions in the search bar. The issue named here is not specific to this script but goes for the API that that script uses in general.

Moving bug to API and adjust summary.
Comment 5 Brion Vibber 2011-02-14 00:33:11 UTC
Patch looks good, applied on trunk in r82096.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links