Last modified: 2011-02-08 21:56:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27638, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25638 - Allow explicit marking of follow-up revisions
Allow explicit marking of follow-up revisions
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 26013 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-24 17:59 UTC by Roan Kattouw
Modified: 2011-02-08 21:56 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Mock-up of associate follow-up revisions & sign-off features (65.08 KB, image/png)
2010-10-25 20:17 UTC, Trevor Parscal
Details
Concept for bug 25638 (76.27 KB, image/png)
2010-10-26 13:07 UTC, Krinkle
Details
Improved version of code review mockup (86.04 KB, image/png)
2010-10-26 17:57 UTC, Trevor Parscal
Details

Description Roan Kattouw 2010-10-24 17:59:51 UTC
It's very annoying when you forget to mention a follow-up in a commit summary and are not able to get the revisions linked. There should be a manual way to do this; Trevor has some ideas about a UI.
Comment 1 Trevor Parscal 2010-10-25 20:17:15 UTC
Created attachment 7755 [details]
Mock-up of associate follow-up revisions & sign-off features

This is a mockup of how we should probably layout the associate follow-up revisions and sign-off features.
Comment 2 Krinkle 2010-10-25 23:12:45 UTC
(In reply to comment #1)
> Created attachment 7755 [details]
> Mock-up of associate follow-up revisions & sign-off features
> 
> This is a mockup of how we should probably layout the associate follow-up
> revisions and sign-off features.
Looks nice.
One suggestion though, a way of undo'ing such association would be handy.
Comment 3 Trevor Parscal 2010-10-25 23:28:19 UTC
Yes, I agree, I will try and work that into another mockup...
Comment 4 Sam Reed (reedy) 2010-10-26 12:38:02 UTC
Small col on the right hand side with an X in it?

On another note, being able to remove erroneous follow up revisions from bad commit messages, that'd be cool (though, part of the same process)

The commit message can't be changed, but the followup table can be cleaned on the followed up bug :)

Looks good though! :D
Comment 5 Krinkle 2010-10-26 13:07:51 UTC
Created attachment 7756 [details]
Concept for bug 25638

DOM manipulation on http://www.mediawiki.org/wiki/Special:Code/MediaWiki/74525
Comment 6 Sam Reed (reedy) 2010-10-26 13:52:12 UTC
I dislike the term "Dissociation"
Comment 7 Trevor Parscal 2010-10-26 17:57:22 UTC
Created attachment 7757 [details]
Improved version of code review mockup

This version includes the ability to strike sign-offs and remove associations.
Comment 8 Roan Kattouw 2010-11-25 16:03:14 UTC
*** Bug 26013 has been marked as a duplicate of this bug. ***
Comment 9 Roan Kattouw 2010-11-25 21:44:54 UTC
Sign-off part (bug 26014) done in r77302.
Comment 10 Sam Reed (reedy) 2010-12-02 02:11:03 UTC
In r77374, Roan did the bulk of the work for this
Comment 11 Roan Kattouw 2010-12-02 17:21:43 UTC
This is done now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links