Last modified: 2010-12-28 23:50:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27567, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 25567 - Include xx% into 'mwe-uploaded-status'
Include xx% into 'mwe-uploaded-status'
Status: RESOLVED FIXED
Product: mwEmbed
Classification: Unclassified
Add media wizard (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-10-18 20:24 UTC by Raimond Spekking
Modified: 2010-12-28 23:50 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Raimond Spekking 2010-10-18 20:24:08 UTC 
Please include the 'xx% -' from updateProgress: function() into the message:

'mwe-uploaded-status' => '$1% uploaded' 

This way the translation are more flexible. Some languages (like German) puts a space between number and %, "$1 %" and at least one language (Turkish) switch it: "%$1"
Comment 1 Michael Dale 2010-10-18 21:40:39 UTC 
is xx% a special hook for percentage? Can you point me to other msg keys that use this convention?
Comment 2 Raimond Spekking 2010-10-19 07:03:37 UTC 
(In reply to comment #1)
> is xx% a special hook for percentage? Can you point me to other msg keys that
> use this convention?

Sorry, the syntax "xx%" is misleading. xx is my placeholder for the number only.

The relevant code snippet from mw.UploadInterface.js seems to be:

$j( '#up-pstatus' ).html( parseInt( fraction * 100 ) + '% - ' );

I suggest to move the % to the message 'mwe-uploaded-status' with $1 as variable for the number:

'mwe-uploaded-status' => '$1% uploaded'
Comment 3 Michael Dale 2010-12-28 23:50:22 UTC 
should be fixed in r25567  Will sync with the extension shortly.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links