Last modified: 2010-12-29 02:32:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27529, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 25529 - Closed caption button inserts div at bottom of page instead of in player
Closed caption button inserts div at bottom of page instead of in player
Status: RESOLVED FIXED
Product: mwEmbed
Classification: Unclassified
Video player (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Michael Dale
http://en.wikipedia.org/wiki/L%27Orfeo
:
Depends on:
Blocks: 24415
  Show dependency tree / graph
 
Reported: 2010-10-15 00:29 UTC by Ryan Kaldari
Modified: 2010-12-29 02:32 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Ryan Kaldari 2010-10-15 00:29:24 UTC 
In some situations, clicking on the closed caption button inserts the timedTextMenu_mwe_ogg_player_1 div at the end of the body instead of within the player. I've seen this in both Firefox and Safari. When it occurs in Safari it gives the following error:

ResourceLoader.php:945
TypeError: Result of expression 'subPage.title' [undefined] is not an object.

The relevant code seems to be:
var langKey=subPage.title.split('.');
Comment 1 Michael Dale 2010-12-29 02:32:43 UTC 
Can't recreate but sounds like an error caused by a partially empty api response for a subtitles for a given video title. 
At least the error as reported should be fixed in r79155. If you can recreate the error post mwEmbed r180, please re-open this bug
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links