Last modified: 2010-10-14 02:31:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27516, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25516 - Localized messages are not being loaded
Localized messages are not being loaded
Status: RESOLVED FIXED
Product: mwEmbed
Classification: Unclassified
Add media wizard (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Michael Dale
http://pt.wikipedia.org/w/index.php?t...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-13 22:37 UTC by Helder
Modified: 2010-10-14 02:31 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Example of the bug (34.02 KB, image/png)
2010-10-13 22:37 UTC, Helder
Details

Description Helder 2010-10-13 22:37:18 UTC
Created attachment 7733 [details]
Example of the bug

Hi!

When we access the page
http://pt.wikipedia.org/w/index.php?title=Wikipedia:Habilite_o_Add_Media_Wizard&withJS=MediaWiki:Gadget-MwEmbed.js
it is shown [mwe-enable-gadget] instead of the text of message (which is already at http://translatewiki.net/wiki/MediaWiki:mwe-enable-gadget/pt).

The English message is displayed correctly if we access the page using "&uselang=en" in the URL.

If some localized message is not available, the English default should be used instead of the current behavior.

The problem also happens with many other messages of the interface when we go to edit mode with the Gadget enabled.

The bug was previously reported at Wikipedia, 
http://en.wikipedia.org/wiki/Wikipedia_talk:WikiProject_Lights_Camera_Wiki#Portuguese_localisation
but I thought here would be a better place
Comment 1 Helder 2010-10-13 22:38:11 UTC
Marking as "major" since it makes the feature unusable.
Comment 2 Michael Dale 2010-10-14 01:27:35 UTC
Thanks for pointing this out. I have updated all the messages with the latest translatewiki translations and set it it to use the English fallback were it can't find the localized string in r74758 and deployed it. 

Also the pt gadget was pointing to an old version of the gadget. I have updated the path on the gadget.

I have also renamed the gadget to match the resource checks and default rewrite rules ie there should be two pages one 'MediaWiki:MwEmbed.js' used for rewrite urls and the gadget 'MediaWiki:Gadget-mwEmbed.js' used for turning on the gadget permanently. 

Now links like the following should work and give you a working 'enable this gadget button' in your local language:
http://pt.wikipedia.org/w/index.php?title=Wikipedia:Habilite_o_Add_Media_Wizard&action=edit&withJS=MediaWiki:MwEmbed.js
Comment 3 Helder 2010-10-14 01:59:45 UTC
Thanks for your help!
It seems to be working now.


Questions:
* When I have the gadget enabled in my preferences and I click in the link
http://en.wikipedia.org/w/index.php?title=Wikipedia:Enable_the_Add_Media_Wizard&withJS=MediaWiki:MwEmbed.js
(which is in that page) the button in the top is not shown. Is this the expected behavior? Shouldn't it display some message like "You already have mwEmbed enabled"?
* If I click in "edit" and "preview" the edition of that same page, the video in the right side changes to the old interface. Shouldn't it use html5 in preview too?

Should I create new bug reports for some of these things?
Comment 4 Michael Dale 2010-10-14 02:31:31 UTC
Yes once you have the gadget enabled it does not give you a link to enable the gadget. 

Fixed the preview page rewrite video player display in r74764 and updated prototype

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links