Last modified: 2013-06-18 16:53:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27498, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25498 - Make limitSelector array configurable from LocalSettings.php
Make limitSelector array configurable from LocalSettings.php
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Translate (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Niklas Laxström
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-12 11:09 UTC by Daniel Tar
Modified: 2013-06-18 16:53 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed patch (1.18 KB, patch)
2010-10-12 12:11 UTC, Daniel Tar
Details

Description Daniel Tar 2010-10-12 11:09:02 UTC
You use a predefined array for limit selector in TranslatePage.php line 275 (as of r74652). Please make it configurable from LocalSettings.php, so I dont have to edit original files when I update Translation extension (I use big message groups, like ~6000, so to expose bigger lists to less advanced users, who don't like/know changing URL-addresses by hand, I have to use this solution). It's relatively easy thing to do, I can provide a patch if needed.
Comment 1 Niklas Laxström 2010-10-12 11:20:36 UTC
Is there reason you need to show all messages at once? I think the only use case for that is for searching with the browsers inbuilt search mechanism, since there is no better alternative for it yet.

If you download the extension directly from SVN you don't need to patch it all the time, but you might get conflicts on updating.

I can apply a patch if you have one.
Comment 2 Daniel Tar 2010-10-12 12:11:34 UTC
Created attachment 7728 [details]
Proposed patch

I've attached the patch. Please tell me if there is any un-MediaWikish coding :)
The reason is that the coherent messages are very scattered in that one large file we working on, and we want to translate these coherent messages together, not linearly, as they are in the file. We cound jump back and forth, but it's just a waste of time :) As you told, the problem occours while updating the extension (and yeah, I use the latest version from SVN), so it would be one less fix I have to apply to Translate extension files. (And easier to change the limits for everybody else :) )
Comment 3 Niklas Laxström 2011-07-11 11:35:48 UTC
I've updated the limits to array( 100, 1000, 5000 ); Is this good enough for you or would you still like to have the patch applied?
Comment 4 Niklas Laxström 2011-08-31 08:04:52 UTC
Assuming fixed if nobody comments.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links