Last modified: 2010-12-29 02:51:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27495, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25495 - Height of textarea in Share dialog of video player
Height of textarea in Share dialog of video player
Status: RESOLVED FIXED
Product: mwEmbed
Classification: Unclassified
Video player (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Michael Dale
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-11 22:29 UTC by Derk-Jan Hartman
Modified: 2010-12-29 02:51 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
screen shot of share screen (98.78 KB, image/png)
2010-10-12 01:13 UTC, Michael Dale
Details
screenshot of Safari, Mac (23.81 KB, image/png)
2010-10-22 13:20 UTC, Derk-Jan Hartman
Details
screenshot windows safari, increased textarea size (38.19 KB, image/png)
2010-12-29 02:51 UTC, Michael Dale
Details

Description Derk-Jan Hartman 2010-10-11 22:29:14 UTC
For me on Safari the size of that textarea is might small (always has been, never thought to mention it before).

My CSS style there for .mv-player .overlay-win textarea {} says "height:15px", which isn't really readable.

I also note it has "width: 100%", but that is not really ok, because 100% of the parent div is larger than the available width due to padding in the parent. Suggest using columns and hoping for the best, or otherwise calculating a suited width based on the higher parent with class="overlay-win ui-state-default ui-widget-header ui-corner-all" (The share this video overlay dialog).
Comment 1 Michael Dale 2010-10-12 01:13:23 UTC
Created attachment 7727 [details]
screen shot of share screen

Hmm I don't know if the user needs to see the full embed code. The idea is just give a single line that can be selected. I see it as width 95% 

Attached screen shot of how it looks for me.
Comment 2 Derk-Jan Hartman 2010-10-22 13:20:43 UTC
Created attachment 7750 [details]
screenshot of Safari, Mac
Comment 3 Michael Dale 2010-12-29 02:51:23 UTC
Created attachment 7938 [details]
screenshot windows safari, increased textarea size

I have adjusted the css settings of the text box in r79156 so they should more closely match the text height. At least with windows safari it looks better now

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links