Last modified: 2014-01-24 05:06:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27480, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 25480 - Javascript error in lqt.js


Summary:	Javascript error in lqt.js

Status:	NEW

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	LiquidThreads (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Normal minor (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	http://pt.wikibooks.org/wiki/T%C3%B3p...
Whiteboard:
Keywords:	javascript

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-10-10 12:43 UTC by Helder
Modified:	2014-01-24 05:06 UTC (History)
CC List:	7 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshot of this bug (43.71 KB, image/png) 2010-10-10 12:43 UTC, Helder	Details
Add an attachment (proposed patch, testcase, etc.)

Description Helder 2010-10-10 12:43:01 UTC

Created attachment 7724 [details]
Screenshot of this bug

After I've edited the comment
http://pt.wikibooks.org/wiki/T%C3%B3pico:Wikilivros:Di%C3%A1logos_comunit%C3%A1rios/Imagens_usadas_no_projeto/resposta_%284%29
and changed from it's Firefox tab to another I got the following error in Firebug:
  data.query.threads[threadId] is undefined
  http://pt.wikibooks.org/w/extensions/LiquidThreads/lqt.js?283y
  Line 555

Comment 1 Helder 2012-07-01 01:56:20 UTC

Maybe it should be added a test such as
---
if (typeof data.query.threads[threadId] !== 'undefined') {
  ...
}
---

somewhere?

Comment 2 Alex Monk 2013-02-25 01:55:38 UTC

I'd like a way to reproduce this...

Comment 3 Helder 2013-02-25 11:44:54 UTC

I don't remember seeing this again since I reported it, so I can't provide more specific steps to reproduce this.


Anyway, it still seems fragile to access ".content" without checking if "data.query.threads[threadId]" is defined.

Comment 4 Nischay Nahata 2013-04-07 18:25:24 UTC

There are many places where the code is that fragile. But its important to know what we are fixing. 

I vote to this as invalid as it seems to always remain this vague in the future.

Comment 5 Jaime Lyn 2013-04-18 18:50:12 UTC

I didn't get a screenshot, but I was able to reproduce this (I think, based on the description and my reliance on Google Translate for the Portuguese ;) ) in Firefox.  Editing a comment worked fine in Chrome, however attempting to edit a comment on that page in Firefox would refresh the page and delete the entire comment.

Comment 6 Andre Klapper 2013-04-18 20:22:40 UTC

Jaime: If you can reproduce it, Firebug or JavaScript error console output is very welcome, plus a link/URL where to reproduce.

Comment 7 Jesús Martínez Novo (Ciencia Al Poder) 2013-09-13 13:04:45 UTC

Removing "easy" until clear and consistent steps to reproduce are added.

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links