Last modified: 2012-05-21 16:06:34 UTC
Created attachment 7723 [details] Proposed patch Hi. It would be nice to have this layout table removed. I know it can be a pain sometimes to do something without tables, bu I think in this case it even looks better without the table. Patch attached.
PS: Tested this in both FF 3.6 and IE 6.
This is almost a dupe of bug 24066. Maybe you could fix this patch for RTL as suggested there, and add it to that bug. This bug could then be closed as a duplicate.
RTL? Isn't the message centered anyway? Ho would my patch break LTR/RTL?
I believe the issue was not about the message, but rather the close button/link, that floats to the right, which would break RTL expectations. But I can only suppose; I'm including Siebrand in CC (since he was the one expressing the concerns about directionality in the other bug) so he can clarify, and also update regarding my question there (whether the ResourceLoader deprecates that issue or not).
Assigning this to Mark H. Not sure why such a simple patch has been sitting around for months.
(In reply to comment #4) > I believe the issue was not about the message, but rather the close > button/link, that floats to the right, which would break RTL expectations. But > I can only suppose; I'm including Siebrand in CC (since he was the one > expressing the concerns about directionality in the other bug) so he can > clarify, and also update regarding my question there (whether the > ResourceLoader deprecates that issue or not). In that case the same issue seems to apply to the current version, but... I guess you could change the word `right` to `$ltrRight` and somewhere before `$notice = <<<HTML` add: $ltrRight = $wgLang->alignEnd(); But I'm not really familiar with RTL/LTR usability and I'm not sure if that's a good idea.
Applied the attached patch in https://gerrit.wikimedia.org/r/#change,3951 and added a fix for directionality. Thank you and sorry about the long delay.
*** Bug 24066 has been marked as a duplicate of this bug. ***
Merged.
