Last modified: 2010-10-11 08:33:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27474, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 25474 - Incorrect method call


Summary:	Incorrect method call

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	ResourceLoader (Other open bugs)
Version:	1.17.x
Hardware:	All All

Importance:	Normal critical (vote)
Target Milestone:	---
Assigned To:	Trevor Parscal

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-10-09 19:55 UTC by Borislav Manolov
Modified:	2010-10-11 08:33 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
A trivial patch (575 bytes, patch) 2010-10-09 19:55 UTC, Borislav Manolov	Details
Add an attachment (proposed patch, testcase, etc.)

Description Borislav Manolov 2010-10-09 19:55:58 UTC

Created attachment 7722 [details]
A trivial patch

The method updateModule from MessageBlobStore is defined as follows:

updateModule($name, ResourceLoaderModule $module, $lang = null)

but on MessageBlobStore:333 it is called as

updateModule($module, $lang)

Apparently the first argument $name is missing.

A patch is attached.

Comment 1 Niklas Laxström 2010-10-09 19:58:26 UTC

See r74525.

Comment 2 Borislav Manolov 2010-10-09 20:14:58 UTC

(In reply to comment #1)
> See r74525.

Please take a closer look at the updateModule call. Currently it results in a fatal error:

Catchable fatal error:  Argument 2 passed to MessageBlobStore::updateModule() must be an instance of ResourceLoaderModule, string given, called in mediawiki/includes/MessageBlobStore.php on line 333 and defined in mediawiki/includes/MessageBlobStore.php on line 121

Comment 3 Roan Kattouw 2010-10-11 08:33:32 UTC

Thanks for the patch, applied in r74614.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links