Last modified: 2011-11-17 08:48:09 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27430, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25430 - Fundraising-related Special pages need header and footer messages
Fundraising-related Special pages need header and footer messages
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ContributionReporting (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Ryan Kaldari
: easy, fun-com, fundraising, patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-06 00:34 UTC by MZMcBride
Modified: 2011-11-17 08:48 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch with a separate header and footer message for each page (3.78 KB, patch)
2011-10-23 16:17 UTC, David Baumgarten
Details
Patch with only two messages which are loades on each page (3.05 KB, patch)
2011-10-23 16:18 UTC, David Baumgarten
Details

Description MZMcBride 2010-10-06 00:34:15 UTC
http://wikimediafoundation.org/wiki/Special:FundraiserStatistics
http://wikimediafoundation.org/wiki/Special:ContributionStatistics
http://wikimediafoundation.org/wiki/Special:ContributionTrackingStatistics

None of these Special pages have header or footer messages, making modification of them difficult. I want to be able to add a navigation template to the pages so that it's possible to click from one page to another.
Comment 1 Sumana Harihareswara 2011-10-13 19:30:50 UTC
"This is a really easy bug to knock out - great for a quick fix by a vet or a really gentle introduction to MediaWiki hacking. It simply requires adding some internationalisation messages (which could be empty) that get loaded in the appropriate place on the page, which can then be overridden on-wiki." -- Arthur Richards
Comment 2 David Baumgarten 2011-10-23 16:17:10 UTC
Created attachment 9272 [details]
Patch with a separate header and footer message for each page
Comment 3 David Baumgarten 2011-10-23 16:18:19 UTC
Created attachment 9273 [details]
Patch with only two messages which are loades on each page
Comment 4 David Baumgarten 2011-10-23 16:18:27 UTC
Hello,
I'm new to MediaWiki hacking, so i hope that this patch is OK.
I wasn't quite sure if you want for each page a separate header and footer or one header and footer for all three pages so I've made both options. 
sixmessages.patch is the patch where each page has it's own header and footer internationalization
 message.
twomessages.patch is the patch with two internationalization messages which are loaded in the appropriate place on each page.
Comment 5 Sumana Harihareswara 2011-11-02 23:35:29 UTC
David, thanks for the patch!  I'm finding a reviewer to look at your work as soon as possible.  In the meantime, please check out https://www.mediawiki.org/wiki/Annoying_little_bugs and try to fix more!  :-)
Comment 6 Mark A. Hershberger 2011-11-04 20:12:23 UTC
r102036
Comment 7 Arthur Richards 2011-11-14 00:09:00 UTC
This was deployed to wikimediafoundation.org on 10 November. David, thanks very much for the patch and helping us close this pesky issue!
Comment 8 Arthur Richards 2011-11-17 08:48:09 UTC
David,

Just wanted to let you know your patch proved to be invaluable tonight. We are currently experiencing technical problems with post-processing of donation information into our tracking system. This means that our fundraiser statistics graph (https://wikimediafoundation.org/wiki/Special:FundraiserStatistics) is not currently being actively updated.

Thanks to your patch, we were able to easily add a notification to the top of the page alerting the many viewers of that graph that it will not be up-to-date until the issue gets resolved.

So, many thanks to you for your incredibly valuable contribution :)

Arthur Richards
Fundraiser engineering lead

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links