Last modified: 2011-05-10 16:45:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27424, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 25424 - Deprecated SpecialPage::addPage() interferes with initialization in unit tests
Deprecated SpecialPage::addPage() interferes with initialization in unit tests
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Unit tests (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-10-05 14:48 UTC by Brion Vibber
Modified: 2011-05-10 16:45 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Brion Vibber 2010-10-05 14:48:37 UTC 
Found when running phpunit tests with ArticleComments extension on, which uses SpecialPage::addPage() instead of directly adding a class to $wgSpecialPages.

$ make destructive
phpunit --configuration /Users/brion/pages/trunk/maintenance/tests/phpunit/suite.xml
Warning: array_merge(): Argument #2 is not an array in /Library/WebServer/Documents/trunk/includes/SpecialPage.php on line 233

SpecialPage::addPage() calls SpecialPage::initList() which attempts to merge in data from $wgSpecialPages. This was set to NULL here, which is unexpected as the default value in DefaultSettings.php is array().
Comment 1 Max Semenik 2011-05-10 16:45:04 UTC 
Seems to  work now.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links