Last modified: 2010-10-13 09:24:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27416, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25416 - PHP Notice: Undefined index: editfont in /includes/ResourceLoaderModule.php on line 968
PHP Notice: Undefined index: editfont in /includes/ResourceLoaderModule.php o...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-04 16:45 UTC by Raimond Spekking
Modified: 2010-10-13 09:24 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Raimond Spekking 2010-10-04 16:45:02 UTC
Per summary: PHP Notice: Undefined index: editfont in /www/w/includes/ResourceLoaderModule.php on line 968

Seen on Translatewiki.
Comment 1 Roan Kattouw 2010-10-04 16:54:54 UTC
Siebrand reported this too, but I have no idea why it's happening. I can't reproduce it, and from looking at the code it should be impossible.

'editfont' is defined in $wgDefaultUserOptions , so unless your config overwrites that var I don't see how 'editfont' could not be in the options array for a given user.
Comment 2 Dmitriy Sintsov 2010-10-05 06:56:24 UTC
I have the same notice with latest 1.17 trunk, too. I don't have $wgDefaultUserOptions overriden anywhere in LocalSettings.php, or that is somewhere else? My test wiki (for development purposes) was 1.16 trunk, now svn update'd to 1.17 trunk then 'php update.php'. Why don't just check array index with isset() or suppress with @ ? Extra warnings in error.log are not a good thing.
Comment 3 Niklas Laxström 2010-10-05 07:18:53 UTC
We haven't run the preferences conversion script, so there might still be some old style preferences in the database. Could that affect it?
Comment 4 Roan Kattouw 2010-10-06 14:30:23 UTC
(In reply to comment #3)
> We haven't run the preferences conversion script, so there might still be some
> old style preferences in the database. Could that affect it?
I think that might just be it. That'd be a bug in the preferences rewrite. Will investigate.
Comment 5 Roan Kattouw 2010-10-11 14:21:34 UTC
There seems to have been a bug in the backwards compatibility code for old-style preferences, which I hope to have fixed in r74625. Could you test with that rev and see if the warnings go away?
Comment 6 Dmitriy Sintsov 2010-10-13 09:24:29 UTC
I've updated to r74716 and the warning went away. Thank you, Roan!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links