Last modified: 2011-06-25 05:05:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27390, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25390 - autoreview privilege should be removeable - like editor
autoreview privilege should be removeable - like editor
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on: 24948 25428
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-02 07:44 UTC by lampak
Modified: 2011-06-25 05:05 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description lampak 2010-10-02 07:44:11 UTC
Currently the autoreview group is implicit and cannot be directly removed or granted. It can be removed only indirectly by blocking a user for a second but it's not very elegant solution. IMHO autoreview should work in the same way as editor. 

On Polish wikipedia this issue has been one of the reasons against introducing the autoreview group. We should be able to strip a vandal from this privilege or promote a non-vandal. 

If you decide to solve this bug, you could use the opportunity to remove the copy-pasted code in checkAutoPromote() and maybeMakeEditor(). Or even better, to have a look at bug 24948.
Comment 1 Bawolff (Brian Wolff) 2010-10-02 17:31:22 UTC
Isn't this a configuration issue. You can (already) create a group that revokes autoreview to anyone in the group (Untrusted people). You can also have an assignable autoreview group.(Of course you can't really remove the implicit group, but creating another group that removes the same privileges amounts to the same thing imho)

For example, on enwikinews, only people in the bot group have autoreview, and you can't get autoreview unless you are a bot.
Comment 2 lampak 2010-10-02 18:20:31 UTC
Yeah, but I would treat it more like a workaround for current software limitations rather that a real solution. It's against intuition and excessively complicated (three groups instead of one) and as such has no chance of getting approval of any wiki community (they're saying one new group would be too many, I won't try with three). If it were a neat solution the editor group would work this way but because of some good reasons it doesn't.
Comment 3 Rob Lanphier 2010-10-04 20:40:42 UTC
Marking this one as blocked by bug 24948, since it doesn't make sense to add a lot of new code in this area without first getting the functionality into the core somehow.
Comment 4 lampak 2010-10-05 20:18:52 UTC
I've made another bug report: bug 25428. And changed the block for dependency - if both bugs are done, this one shouldn't be a problem (I hope).
Comment 5 Aaron Schulz 2011-03-22 16:57:12 UTC
So this is about users that had the implicit group and were once blocked or is it more general? For, now the block log can be checked until more is done.
Comment 6 Aaron Schulz 2011-06-25 05:05:41 UTC
Done in r90756.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links