Last modified: 2010-12-23 20:17:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 25386 - load.php outputs HTML on exceptions
load.php outputs HTML on exceptions
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.17.x
All All
: Normal normal (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks: 24415
  Show dependency treegraph
 
Reported: 2010-10-01 15:55 UTC by Max Semenik
Modified: 2010-12-23 20:17 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Max Semenik 2010-10-01 15:55:57 UTC
It outputs the standard "Internal error" page. Probably, it should output something like "/* Internal error: [error message] */" instead, but certainly not HTML. Discovered while investigating bug 25338.
Comment 1 Roan Kattouw 2010-10-01 15:58:07 UTC
Note that we can only fix this to a certain degree. We can change what the exception handler outputs for load.php, but uncatchable fatal errors will still be output as HTML.
Comment 2 Trevor Parscal 2010-10-01 18:12:42 UTC
There's a comment in the code to this effect - it's on the todo list, thanks for filing a bug for it.
Comment 3 Trevor Parscal 2010-11-04 17:51:19 UTC
I think this can be closed, exceptions are now output as /* exception content */ comments in both JS and CSS.
Comment 4 Roan Kattouw 2010-12-23 20:17:19 UTC
(In reply to comment #3)
> I think this can be closed, exceptions are now output as /* exception content
> */ comments in both JS and CSS.
This wasn't true, you probably meant PHP warnings. Exceptions were done in r78924.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links