Last modified: 2012-03-06 23:16:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27381, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25381 - Port SemanticMediaWiki to ResourceLoader
Port SemanticMediaWiki to ResourceLoader
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Semantic MediaWiki (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Markus Krötzsch
:
Depends on:
Blocks: 29713
  Show dependency treegraph
 
Reported: 2010-10-01 06:48 UTC by denny vrandecic
Modified: 2012-03-06 23:16 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description denny vrandecic 2010-10-01 06:48:57 UTC
Firebug sometimes says:

addOnloadHook(smw_sortables_init); is not defined

Appears when a query result of format table is on the page.

Need to figure out, why exactly, and remove the bug.
Comment 1 Niklas Laxström 2010-10-01 06:56:06 UTC
With the new resource loader or without?
Comment 2 denny vrandecic 2010-10-01 08:38:47 UTC
The two MediaWikis in question have both been rather recent versions from SVN trunk, so if resource loader is installed by deafult on them, then yes.
Comment 3 p858snake 2010-10-01 09:39:12 UTC
Try updating your semantic extensions, AFAIK addonloadhook has been removed from core because resource loader handles that, and I'm pretty sure the extensions have been updated to handle that.
Comment 4 Niklas Laxström 2010-10-01 09:44:34 UTC
It's not removed yet, but it is loader later. I think jQuery's ready() method is suitable replacement.
Comment 5 Roan Kattouw 2010-10-02 19:11:12 UTC
(In reply to comment #4)
> It's not removed yet, but it is loader later. I think jQuery's ready() method
> is suitable replacement.
Yes and yes. Use $(document).ready(function() { code here} );
Comment 6 Krinkle 2010-12-09 20:31:55 UTC
I see several commits in this folder related to resource loader fixes. Are the errors still appearing / are there any components yet to be fixed due to changes by resourceloader ?
Comment 7 Krinkle 2011-06-04 17:25:41 UTC
Removing dependancy on ResourceLoader 1.0 implementation. This is a seperate issue.

(In reply to comment #6)
> I see several commits in this folder related to resource loader fixes. Are the
> errors still appearing / are there any components yet to be fixed due to
> changes by resourceloader ?

*bumping* the above question.
Comment 8 Markus Krötzsch 2011-08-22 12:22:51 UTC
I think this can be closed. SMW no longer has its own copy of the sorting tables script and it is well integrated with ResourceLoader in general.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links