Last modified: 2011-08-01 00:09:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T4537, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 2537 - Ability to preview summary in "Upload file" page
Ability to preview summary in "Upload file" page
Status: NEW
Product: MediaWiki
Classification: Unclassified
Uploading (Other open bugs)
unspecified
All All
: Normal enhancement with 11 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 5473 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2005-06-26 16:11 UTC by Eugene Zelenko
Modified: 2011-08-01 00:09 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Eugene Zelenko 2005-06-26 16:11:01 UTC
Will be great to have ability to preview file description typed in "Summary"
field of "Upload file" page. Just to verify license tags, links and so on.

Preview should be displayed in pop-up window.
Comment 1 lɛʁi לערי ריינהארט 2005-06-26 22:01:14 UTC
How does this request relate to bug 2258 and bug 73 ?
Comment 2 Brion Vibber 2005-06-26 22:39:17 UTC
It doesn't.
Comment 3 Rob Church 2006-03-29 00:27:30 UTC
Pinging for thoughts on this prior to possible implementation.
Comment 4 Brion Vibber 2006-04-05 23:40:16 UTC
*** Bug 5473 has been marked as a duplicate of this bug. ***
Comment 5 Filip Maljkovic [Dungodung] 2006-05-04 12:17:31 UTC
Ponging... There could be a [Preview] button next to the [Submit] button, much
alike the normal editing form. When the preview shows, the image path, name and
license should stay intact (of course). There is one thing that's bothering me:
where to actually put the preview? The troublemaker is the
[[MediaWiki:uploadtext]]. The question is: in which order should the contents be
shown?
1) Uploadtext, preview then form?
2) Preview, uploadtext and form?
3) Preview and form, no uploadtext

While 1) seems like a good compromise, I'd prefer 3) because uploadtext isn't
really needed after the first load of the upload page.

Just spilling some ideas
Comment 6 Brion Vibber 2006-05-04 18:58:03 UTC
It's not possible to actually do that. Either we upload the file 
with the preview form submission, or you have to select it again 
on the preview display.
Comment 7 Rob Church 2006-05-04 18:59:50 UTC
The idea I had was that uploads would still be associated with summaries, but
that during the first upload of an image, the user would also see a medium-sized
text box (with edit toolbar?) allowing them to enter initial additional content
for the description page.

If this was submitted blank, then the contents of the summary field, if any,
would be used as before. The description page could be previewed prior to
submission in some manner. As Brion states, however, there's a problem when we
consider that the file is attached to that form, and is going to be submitted
along with the rest of it if the user hits Upload, Preview, etc.
Comment 8 Brion Vibber 2006-05-04 19:02:02 UTC
Or... the preview can be AJAX. ;)
Comment 9 Magnus Manske 2006-06-13 11:49:08 UTC
My first thought was to have an Preview button do exactly what Upload does,
except saving the description, but instead opening the edit page of the
description with the prefilled text.

However, if the user doesn't save the page, the image would be without
description page, which is bad.

So, why not
* Perform a complete upload on preview, also saving the description
* Immediately open the edit page of the description, with preview
This ensures an initial description is saved, and the user can "fine-tune" the
description using preview. The only drawback here is generating two versions of
the description per preview-upload. But then, we do cope with old versions
rather well ;-)
Comment 10 Eugene Zelenko 2006-06-13 13:07:44 UTC
My point was to reduce number of revisions for image descriptions. To check
links/categories for existence before uploading image.
Comment 11 Dan Jacobson 2007-08-27 22:25:16 UTC
Anyway, users are used to the right to preview anything before committing.
Whereupon they encounter this upload form with a missing preview button.
Anyway, whatever you do, don't make it depend on javascript, css, etc.
Test in lynx, etc. 
Comment 12 Stewart Gordon 2007-11-02 21:18:06 UTC
Why only the summary?  A single operation should preview the summary and the uploaded media in one go.  This is especially important for checking that SVGs are within MediaWiki's rendering capability.
Comment 13 Michael Dale 2009-08-21 15:39:33 UTC
hmm... this should actually not be too hard to do now that we normal uploads on Secial:Upload being submited to the api see recent versions of the special upload page with js2enabled. We are doing an api upload request to an iframe.

I think we could reclassify this bug as adding a "preview" option to the upload api. The "preview" option would take the upload put it in a "stash" then return a rendered thumbnail transform. (and wiki-text parse the comment field along with other warning checks). 
Comment 14 Bryan Tong Minh 2009-10-16 20:38:17 UTC
Assigning to self. I intend to fix this, at least for the non-AJAX part. I think Michael Dale's feature is nice and should be implemented, but users who do not use JavaScript should be able to use the major functions of the site as well, so this should at first be implemented in pure HTML.

The idea behind the implementation will be the same, a button "upload and preview comment", which will upload the image to stash and show a preview of the comment with an option to save or cancel.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links