Last modified: 2012-04-12 13:53:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27292, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25292 - SkinSubPageSubtitle described as taking 2 parameters, but only implements 1
SkinSubPageSubtitle described as taking 2 parameters, but only implements 1
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
1.16.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://www.mediawiki.org/wiki/Manual:...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-09-24 23:18 UTC by justin
Modified: 2012-04-12 13:53 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description justin 2010-09-24 23:18:11 UTC
The hook SkinSubPageSubtitle is listed as taking in 2 parameters, the Skin object and the Subtitles variable (http://www.mediawiki.org/wiki/Manual:Hooks/SkinSubPageSubtitle). The actual hook only implements the passing of the subtitles variable on (approximately) line 1144 of Skin.php:

if( !wfRunHooks( 'SkinSubPageSubtitle', array( &$subpages ) ) ) 

Passing the Skin object would prove immensely helpful in the creation of my extension to modify the subpages display, as the mTitle object is protected. 

Let me know if you have any questions, or if I missed something in using this hook.
-Justin
Comment 1 Alexandre Emsenhuber [IAlex] 2010-09-26 16:37:36 UTC
Fixed in r73783.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links