Last modified: 2013-01-28 19:10:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 25277 - invisible directional character on File page pollutes pasted filenames
invisible directional character on File page pollutes pasted filenames
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.16.x
All All
: Low normal (vote)
: ---
Assigned To: Amir E. Aharoni
: i18n
Depends on:
Blocks: rtl
  Show dependency treegraph
 
Reported: 2010-09-23 20:42 UTC by Lee Worden
Modified: 2013-01-28 19:10 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
add a space between an anchor and the dirmark (1.01 KB, patch)
2010-09-29 18:48 UTC, Antoine "hashar" Musso (WMF)
Details

Description Lee Worden 2010-09-23 20:42:44 UTC
The File page outputs an invisible Unicode directional character ("Left to Right Mark" or its counterpart) just after the link to the raw file, with no space intervening.

That's, for instance, here on line 479 of ImagePage.php (r73636):
 <span class="dangerousLink">{$medialink}</span>$dirmark

This means that when a user copies the filename from that link in order to paste it into a wiki page, the invisible character is pasted as well.  This can cause problems in the wiki page and is hard to troubleshoot because the offending character is invisible.

I don't know anything about bidirectional text, so I don't have a patch, but can't that mark be separated from the link text, or even converted into an html attribute or something?
Comment 1 Antoine "hashar" Musso (WMF) 2010-09-29 18:48:23 UTC
Created attachment 7711 [details]
add a space between an anchor and the dirmark

$dirmark was added to this message in r15352 :
r1=15352&r2=15353&pathrev=49895">http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/ImagePage.php?r1=15352&r2=15353&pathrev=49895&

This patch fixes other possible occurences.
Comment 2 Sumana Harihareswara 2011-10-07 19:21:54 UTC
Added "i18n" tag since I don't see an rtl tag.
Comment 3 Amir E. Aharoni 2011-12-25 12:28:18 UTC
The usual way to mark RTL bugs is to mark them as blocking bug 745. I'll take a look at it.
Comment 4 Robin Pepermans (SPQRobin) 2011-12-25 18:21:21 UTC
I think it's safe to remove the dirmark, it didn't make any visual difference as far as I tested.
Comment 5 Amir E. Aharoni 2012-03-29 19:22:10 UTC
The dirmark can have influence here. The file description can begin with a type, like "PNG", and the file name usually ends in Latin characters, so it can get messy.

I applied a patch similar to the one that is attached at https://gerrit.wikimedia.org/r/3929 .
Comment 6 Alex Monk 2013-01-28 17:48:37 UTC
That change is merged. What is left to do for this bug? Is it done?
Comment 7 Amir E. Aharoni 2013-01-28 19:10:58 UTC
Thanks for the reminder!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links