Last modified: 2011-01-06 02:54:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27254, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25254 - Using a sortkey longer than the db field causes cl_timestamp to be updated on every page save (including null edits) even if the edit did not touch the category
Using a sortkey longer than the db field causes cl_timestamp to be updated on...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Categories (Other open bugs)
1.17.x
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 26566 (view as bug list)
Depends on: 16287
Blocks: 16602
  Show dependency treegraph
 
Reported: 2010-09-22 21:11 UTC by Bawolff (Brian Wolff)
Modified: 2011-01-06 02:54 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bawolff (Brian Wolff) 2010-09-22 21:11:24 UTC
Splitting off from Bug 25012

Steps to reproduce:
*Add a page to a category and use a really long sortkey (on whats running on wikimedia greater than 86 bytes, for trunk greater than 255 bytes)
*Look up the cl_timestamp using db or api
*do a null edit
*Look up cl_timestamp

Expected behaviour: cl_timestamp should be the same both times (and equal to the first time you edit the page)

Actual behaviour: 
cl_timestamp is the time you did a null edit.


Presumably what happens is mediawiki thinks your sortkey is one thing, it gets truncated when entered into the db, then next time mediawiki thinks the sortkey is the full sortkey, but db thinks its the truncated sortkey, so it assumes the sortkey has changed and updates cl_timestamp. (rinse and repeat each save)


This is particularly noticeable with the non-latin wikinews projects, as the utf-8 encoding of their scripts are bigger, and its more common for the page title to not fit in the sortkey field (presumably with categorylinks table changing sortkey to having a size limit of 255 bytes, this will be alleviated as thats the limit for page names too, however the new sortkey scheme is also supposed to be much bigger for other languages from what i hear so maybe not, anyways it would still a bug when a user manually enters a huge sortkey). These wikinews editions then use DPL, which relies on cl_timestamp not doing this type of thing.


btw there is also an open bug requesting that sortkey changes do not modify cl_timestamp - bug 16287. I think that'd be cool from a DPL prespective, and would solve this issue, but I'm not sure if thats an intended behaviour or not.


p.s. Hopefully i used the depends on/blocks fields correctly as i've never used them before
Comment 1 Aryeh Gregor (not reading bugmail, please e-mail directly) 2010-09-26 12:01:24 UTC
I'll see if I can look at this soon, but I can't promise anything.
Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2010-10-08 20:18:05 UTC
I doubt I'm going to get around to this anytime soon.
Comment 3 Bawolff (Brian Wolff) 2011-01-05 11:19:36 UTC
*** Bug 26566 has been marked as a duplicate of this bug. ***
Comment 4 Bawolff (Brian Wolff) 2011-01-06 00:03:42 UTC
I might try to look at this.
Comment 5 Bawolff (Brian Wolff) 2011-01-06 02:44:30 UTC
fixed in r79706

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links