Last modified: 2012-06-19 22:23:24 UTC
I'm currently seeing this in my page source: <script>mediaWiki.config.set(...);</script> <script>if ( mediaWiki !== undefined ) { mediaWiki.loader.load( ... ); mediaWiki.loader.go(); }</script> Seems kinda ridiculous to me. The config.set() call should be merged into the bottom one and also be inside the if ( mediaWiki !== undefined ) block.
Please read the code that generates this... http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/OutputPage.php?view=markup#l2352 You will see that while I want to combine them, Skin::makeGlobalVariablesScript returns a complete script tag, not just JavaScript code. We will need to go deeper into the treacherous depths of MediaWiki to fix this - it was outside the scope of an already huge set of changes, so I skipped it at the time.
So it's not easy to fix, that's fine then. It would still be nice to have makeGlobalVariablesScript() wrap its output in if ( mediaWiki !== undefined ) for consistency, though.
Removing dependancy on ResourceLoader 1.0 implementation. Moving to MediaWiki/ResourceLoader category. Not adding as a dependancy for ResourcerLoader 2.0, it's a nice to have but not a requirement.
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734