Last modified: 2012-06-19 22:23:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27202, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25202 - Merge <script> tags output by ResourceLoader in the 'top' and 'bottom' queues.
Merge <script> tags output by ResourceLoader in the 'top' and 'bottom' queues.
Status: NEW
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.17.x
All All
: Low enhancement (vote)
: Future release
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-09-17 14:47 UTC by Roan Kattouw
Modified: 2012-06-19 22:23 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2010-09-17 14:47:00 UTC
I'm currently seeing this in my page source:

<script>mediaWiki.config.set(...);</script>
<script>if ( mediaWiki !== undefined ) { mediaWiki.loader.load( ... ); mediaWiki.loader.go(); }</script>

Seems kinda ridiculous to me. The config.set() call should be merged into the bottom one and also be inside the if ( mediaWiki !== undefined ) block.
Comment 1 Trevor Parscal 2010-09-17 17:09:52 UTC
Please read the code that generates this...

http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/OutputPage.php?view=markup#l2352

You will see that while I want to combine them, Skin::makeGlobalVariablesScript returns a complete script tag, not just JavaScript code. We will need to go deeper into the treacherous depths of MediaWiki to fix this - it was outside the scope of an already huge set of changes, so I skipped it at the time.
Comment 2 Roan Kattouw 2010-09-18 10:04:45 UTC
So it's not easy to fix, that's fine then. It would still be nice to have makeGlobalVariablesScript() wrap its output in if ( mediaWiki !== undefined ) for consistency, though.
Comment 3 Krinkle 2011-06-04 17:27:26 UTC
Removing dependancy on ResourceLoader 1.0 implementation.

Moving to MediaWiki/ResourceLoader category.

Not adding as a dependancy for ResourcerLoader 2.0, it's a nice to have but not a requirement.
Comment 4 Bugmeister Bot 2011-08-19 19:12:54 UTC
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links