Last modified: 2010-09-16 17:21:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27186, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 25186 - Toolbar API: Removing characters is broken
Toolbar API: Removing characters is broken
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
UsabilityInitiative (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-09-16 07:49 UTC by Michael M.
Modified: 2010-09-16 17:21 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Michael M. 2010-09-16 07:49:04 UTC 
Characters can't be removed with removeFromToolbar.

Since r65558, characters are no longer wrapped in an <a> but in a <span>, so the code

if ( typeof data.character == 'string' ) {
   // Character
   //target += ' a[rel=' + data.character + ']';

from ./js/plugins/jquery.wikiEditor.toolbar.js (line 153) must get changed.

If you want to reproduce the bug just run the test script (./js/tests/wikiEditor.toolbar.js), look at the ":))" after it should have been removed and fix bug 25185 as well.
Comment 1 Trevor Parscal 2010-09-16 17:21:03 UTC 
This is fixed in r73123.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links