Last modified: 2014-09-23 19:45:35 UTC
Steps to reproduce: 1. Delete all wikiEditor-* cookies. 2. Run the test script (./js/tests/wikiEditor.toolbar.js). 3. Look at the created cookies: Two cookies are created, wikiEditor-0-booklet-colors-page and wikiEditor-0-booklet-removeme-page, both with value "colors" (which is the first page in the booklet containing the pages "colors" and "removeme"). Expected behavior: Only one cookie for the opened section (wikiEditor-0-toolbar-section), and one for each booklet (wikiEditor-0-booklet-info-page, in this case) should be created, when the user opens something (this works as expected), but not one cookie for each page.
Created attachment 8782 [details] Proposed patch In two places updateBookletSelection was called with the name of the page instead of the name of the section. The patch fixes this. Additionaly, when only the default (i. e. the first) page is selected, storing this in a cookie isn't necessary, so I removed this, too.
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Michael, thank you for the patch, and my apologies that no one has reviewed it and responded yet. I'm marking this bug with "need-review" as a keyword, to signal that this patch is awaiting code review. Thanks again. If you want to talk about your patch and get it reviewed faster, please feel free to visit #mediawiki in freenode IRC -- http://webchat.freenode.net/?channels=#mediawiki .
Michael: Thanks again for the patch. Are you interested in using developer access to directly suggest it into our Git source control system? https://www.mediawiki.org/wiki/Developer_access https://www.mediawiki.org/wiki/Git/Workflow#How_to_submit_a_patch
