Last modified: 2010-09-16 13:59:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27182, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25182 - Revision 72797 breaks 'vector' skin
Revision 72797 breaks 'vector' skin
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.17.x
All All
: Normal normal (vote)
: ---
Assigned To: Trevor Parscal
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-09-15 20:08 UTC by Joris
Modified: 2010-09-16 13:59 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Joris 2010-09-15 20:08:47 UTC
Since rev 72797 I get the following error (results in vector skin only showing plain text in Chrome)

<b>Warning</b>:  file_exists() [<a href='function.file-exists'>function.file-exists</a>]: open_basedir restriction in effect. File(/wiki/skins/common/images/add.png) is not within the allowed path(s): (/var/www/vhosts/xxxxxxxx.nl/httpdocs:/tmp) in <b>/var/www/vhosts/xxxxxxxx.nl/httpdocs/wiki/includes/libs/CSSMin.php</b> on line <b>69</b><br />

Which is:
$file = ( isset( $path ) ? rtrim( $path, '/' ) . '/' : '' ) . "{$match['file'][0]}";

replacing '' with './' seems to resolve it but I dont know if this is a proper workaround.
Comment 1 Guillaume Paumier 2010-09-15 20:11:40 UTC
r72797

(to get the automagic link)
Comment 2 Roan Kattouw 2010-09-15 20:14:19 UTC
Meh. Does replacing file_exists() with is_file() fix this? Alternatively, could you try changing this:

if ( file_exists( $file ) ) {
    some code here
}

with

wfSuppressWarnings();
if ( file_exists( $file ) ) {
    some code here
}
wfRestoreWarnings();

and see if that helps?
Comment 3 Joris 2010-09-15 20:31:27 UTC
thnx for the tip Guillaume.

is_file didn't change a thing. SuppressWarnings does.
Comment 4 Roan Kattouw 2010-09-16 13:45:28 UTC
Attempted to fix this in 73115, could you test that?
Comment 5 Joris 2010-09-16 13:59:46 UTC
r73115 solved my problem, but again not really sure if this serves the purpose of the function. Thnx

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links