Last modified: 2010-09-13 23:30:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27146, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 25146 - Resource loader requests are not caching properly
Resource loader requests are not caching properly
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
unspecified
All All
: Normal major (vote)
: ---
Assigned To: Trevor Parscal
http://translatewiki.net/static/rl.ca...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-09-11 16:07 UTC by Niklas Laxström
Modified: 2010-09-13 23:30 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Niklas Laxström 2010-09-11 16:07:25 UTC 
See the example url. All resources are reloaded again every time (and not even 304 response?)
Comment 1 Roan Kattouw 2010-09-13 15:28:47 UTC 
Can you reproduce this with latest trunk? I fixed a bug where we were setting maxage=123 instead of max-age=123 . Also, if you can still reproduce this, please provide the URL of a page where this occurs.
Comment 2 Trevor Parscal 2010-09-13 23:30:18 UTC 
I think this is fixed now - the code was checking if the If-Modified-Since was exactly equal to the requested modules' maximum modified time, rather than checking if it was less than or equal to. See r72940
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links