Last modified: 2014-11-04 22:50:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27141, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25141 - User signatures should be wrapped in a span
User signatures should be wrapped in a span
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
Parser (Other open bugs)
unspecified
All All
: Low enhancement with 6 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 46855 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-09-11 12:24 UTC by paxed
Modified: 2014-11-04 22:50 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description paxed 2010-09-11 12:24:22 UTC
Currently there is no way to distinguish between user text and his signature eg. on talk pages, and therefore the signatures cannot be styled separately from the text either.
Comment 1 Alex Monk 2013-04-03 22:31:18 UTC
*** Bug 46855 has been marked as a duplicate of this bug. ***
Comment 2 Technical 13 2013-04-03 22:45:25 UTC
(In reply to comment #1)
> *** Bug 46855 has been marked as a duplicate of this bug. ***

This bug did not come up in my search, but it is extremely similar.
I'm requesting that all signatures be wrapped in a set of classed tags so that
those editors with vision problems (like myself) can add a little css or
javascript (or have a checkbox that lets it be done server side on their
preferences page) to remove custom signatures from everyone. I've seen on WP
talk:signatures there was a request to have all custom signatures removed from
this site, and my suggestion here would allow those people that think they
shouldn't be allowed for anyone if they are not fully customizable and allowed
for everyone to disable all signature customizations.  To summarize, I am
requesting signatures be wrapped in an element to allow users to add something
like:
span.signature {background-color: #FFF; color: #000; text-decoration: none;
font-family: "Times New Roman", monospace;}

Allowing them to remove blinking, scrolling, and colors that are too bright and
fail to meet standards of contrast ratios without having to request every user
that has an obnoxious signature to fix it wasting time and causing conflicts
and edit wars.

I don't care what the element tag is and I don't care much what the class is.  An expansion of <span class="before-localcomments"> to include the whole signature and not just the ) and times stamp would work fine for me.
Comment 3 Gerrit Notification Bot 2014-04-28 16:52:56 UTC
Change 130094 had a related patch set uploaded by Gerrit Patch Uploader:
Wrap user signatures in a span

https://gerrit.wikimedia.org/r/130094
Comment 4 PiRSquared17 2014-04-28 17:20:14 UTC
This could add a lot of extra text to pages for ~~~ and ~~~~. Thoughts?
Comment 5 Nemo 2014-09-30 21:04:26 UTC
My thought is: No, thanks.
Comment 6 Nemo 2014-09-30 21:32:51 UTC
I recommend WONTFIX per Brion https://lists.wikimedia.org/pipermail/wikitech-l/2014-September/078855.html
Comment 7 Diana 2014-10-06 17:08:42 UTC
+1 for this enhancement.

I'd suggest to add two classes: a specific class based on username or user ID (e.g. "user_john" or user_28746) and a general class (e.g. "user_signature") if <sig> or <author> can't be in use. Also, different user levels can have classes such "user_admin", "user_bureaucrat" etc.

This fix will add the extra text to pages but as far as I know text amount is not a concern, the issue here is to allow user do mute others signature styles while allowing everybody to custom them freely.
Comment 8 Technical 13 2014-10-06 18:05:47 UTC
(In reply to Diana from comment #7)
> +1 for this enhancement.
> 
> I'd suggest to add two classes: a specific class based on username or user
> ID (e.g. "user_john" or user_28746) and a general class (e.g.
> "user_signature") if <sig> or <author> can't be in use.

Why based on username?  I think that would be too specific.

> Also, different user
> levels can have classes such "user_admin", "user_bureaucrat" etc.

Interesting idea, that I support.

> This fix will add the extra text to pages but as far as I know text amount
> is not a concern,

I don't see any reason this should add extra text to what readers or editors see, as these classes and whatnot can be added by the parser upon rendering.

> the issue here is to allow user do mute others signature
> styles while allowing everybody to custom them freely.

That is indeed the issue this ticket aims to offer a fix for.
Comment 9 Diana 2014-10-06 19:26:12 UTC
(In reply to Technical 13 from comment #8)
> (In reply to Diana from comment #7)
> > +1 for this enhancement.
> > 
> > I'd suggest to add two classes: a specific class based on username or user
> > ID (e.g. "user_john" or user_28746) and a general class (e.g.
> > "user_signature") if <sig> or <author> can't be in use.
> 
> Why based on username?  I think that would be too specific.
> > > Yes, as specific as signatures are. An username/ID-based class will allow users to style their signatures (and the others) through their user stylesheet. Also users can create scripts (through the user js) that can rely on classes more easily, e.g. a toc for comments in discussions. 
> > Also, different user
> > levels can have classes such "user_admin", "user_bureaucrat" etc.
> 
> Interesting idea, that I support.
> 
> > This fix will add the extra text to pages but as far as I know text amount
> > is not a concern,
> 
> I don't see any reason this should add extra text to what readers or editors
> see, as these classes and whatnot can be added by the parser upon rendering.
> > > If so, that's great!
> >
> > the issue here is to allow user do mute others signature
> > styles while allowing everybody to custom them freely.
> 
> That is indeed the issue this ticket aims to offer a fix for.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links