Last modified: 2011-06-06 22:09:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27124, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25124 - Resource loader should respect $wgStyleDirectory
Resource loader should respect $wgStyleDirectory
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
1.17.x
All All
: Normal minor (vote)
: ---
Assigned To: Krinkle
:
Depends on:
Blocks: 24415
  Show dependency treegraph
 
Reported: 2010-09-09 23:28 UTC by Bawolff (Brian Wolff)
Modified: 2011-06-06 22:09 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bawolff (Brian Wolff) 2010-09-09 23:28:39 UTC
title says it all - if you set $wgStyleDirectory = "$IP/foo" one would expect the resource loader to look in foo not skins for the bits in skins, but it has skins hardcoded.


On the other hand I personally don't see what benefit wgStyleDirectory has over using a symbolic link if you really had to have the style directory somewhere else than the default, so perhaps the global should just be removed...
Comment 1 Dmitriy Sintsov 2010-11-10 06:34:21 UTC
wgStyleDirectory probably was useful to access skins/common, which used to contain "shared" scripts and images. However, I don't know if that is still recommended for trunk.
Comment 2 Krinkle 2011-06-06 17:01:26 UTC
Ahm..  it does look weird now in Resources.php registry:

		'remoteBasePath' => $GLOBALS['wgStylePath'],
		'localBasePath' => "{$GLOBALS['IP']}/skins",

it's used for remote but not for local, should be a simple fix by putting $wgStyleDirectory there.. no ?
Comment 3 Roan Kattouw 2011-06-06 17:14:35 UTC
(In reply to comment #2)
> Ahm..  it does look weird now in Resources.php registry:
> 
>         'remoteBasePath' => $GLOBALS['wgStylePath'],
>         'localBasePath' => "{$GLOBALS['IP']}/skins",
> 
> it's used for remote but not for local, should be a simple fix by putting
> $wgStyleDirectory there.. no ?
Yeah, that'll work, as long as that var has a sane default. Go for it.
Comment 4 Krinkle 2011-06-06 22:09:01 UTC
Fixed in r89615.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links