Last modified: 2012-04-12 13:54:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27102, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 25102 - Image.php throws E_STRICT error
Image.php throws E_STRICT error
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.16.x
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-09-08 18:22 UTC by Christian Neubauer
Modified: 2012-04-12 13:54 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Christian Neubauer 2010-09-08 18:22:59 UTC 
The declaration of newFromTitle in Image.php doesn't match the declaration in LocalFile.php which causes this E_STRICT error:

Strict standards: Declaration of Image::newFromTitle() should be compatible with that of LocalFile::newFromTitle() in /opt/cruisecontrol-bin-2.8.3/projects/wiki4di/build/wiki/includes/filerepo/Image.php on line 74
Comment 1 Chad H. 2010-09-09 00:54:54 UTC 
Fixed in r72622.

Note that Image.php is ancient. I'm curious what extensions(s) you might be running that are still calling this old code. 

I've also marked it for complete removal in 1.18
Comment 2 Christian Neubauer 2010-09-13 11:39:44 UTC 
Hmm, I'm not sure.  All my extensions use wfLocalFile.  PHP just needs to autoload the file to throw the E_STRICT right?
Comment 3 Chad H. 2010-09-13 11:42:05 UTC 
The file shouldn't be loaded unless the class gets called :)
Comment 4 Christian Neubauer 2010-09-14 15:32:09 UTC 
Yeah good point.  I don't know.  There are no calls to "Image::" or "new Image" in my extensions anywhere.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links