Last modified: 2014-09-24 01:22:17 UTC
A bit like Bug 2044 but not the same: blocked registered users should get a
similar red warning to "you have new messages" telling them that they're bloced,
and should not accidentally try to edit.
So far I wasn't able to find logical reasons against this feature, but if
there's one, I am open to hear about it.
Technical questions another matter, as it may be debated that cache would care
(registered users have different pages anyway), whether lookup is feasible
(autblocking requires that lookup anyway), etc., I listen to them too.
Basic problem is that Wikipedia should not be Evil, and autoblock people because
they accidentally press edit link forgetting that their block is not raised till
the next hour (or even more sucky when they get screwed by Bug 856 ...)
reverting last change (assignment)
What about not irritating users who know they're blocked and can't edit, and
don't want to see a large notice at the top of each page? I'd prefer hiding the
edit tab for users who can't.
I agree with Rob @ #2.
Per Rob's comment, and the filer's agreement with it; I'm closing this bug as
I like the idea of a dismissable warning, as proposed by Brion, however.
Created attachment 4756 [details]
Removes "Edit this page" if blocked.
The following patch will replace "Edit this page" with "View source" if the user is blocked. Not sure if this is how we want to proceed or not, just going on Rob's comment in #2.
Patch applied in r42281
Reverted in r42282, Splarka reminded me that this will break the static html cache :(
That's why the original report was about registered users only.
I was thinking about playing tricks with css, but it'll break _some_ cache _somewhere_ anyway for anon users.
isBlocked() seems expensive to gratuitously call it on every view by registered users.
Why is it bad to wait until they hit edit?
(In reply to comment #10)
> isBlocked() seems expensive to gratuitously call it on every view by registered
> Why is it bad to wait until they hit edit?
I feel the same.
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
+reviewed per comment 8