Last modified: 2014-09-24 01:22:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 2508 - "you are blocked - don't edit" message similar to "you have new messages"
"you are blocked - don't edit" message similar to "you have new messages"
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
All All
: Low enhancement with 4 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks: 4205
  Show dependency treegraph
Reported: 2005-06-24 20:38 UTC by Peter Gervai (grin)
Modified: 2014-09-24 01:22 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Removes "Edit this page" if blocked. (795 bytes, patch)
2008-03-24 19:32 UTC, Chad H.

Description Peter Gervai (grin) 2005-06-24 20:38:14 UTC
A bit like Bug 2044 but not the same: blocked registered users should get a
similar red warning to "you have new messages" telling them that they're bloced,
and should not accidentally try to edit. 

So far I wasn't able to find logical reasons against this feature, but if
there's one, I am open to hear about it. 

Technical questions another matter, as it may be debated that cache would care
(registered users have different pages anyway), whether lookup is feasible
(autblocking requires that lookup anyway), etc., I listen to them too.

Basic problem is that Wikipedia should not be Evil, and autoblock people because
they accidentally press edit link forgetting that their block is not raised till
the next hour (or even more sucky when they get screwed by Bug 856 ...)
Comment 1 T. Gries 2005-08-13 09:12:39 UTC
reverting last change (assignment)
Comment 2 Rob Church 2005-12-14 23:26:17 UTC
What about not irritating users who know they're blocked and can't edit, and
don't want to see a large notice at the top of each page? I'd prefer hiding the
edit tab for users who can't.
Comment 3 Peter Gervai (grin) 2006-01-26 08:58:43 UTC
I agree with Rob @ #2.
Comment 4 Andrew Garrett 2006-11-04 14:18:13 UTC
Per Rob's comment, and the filer's agreement with it; I'm closing this bug as
Comment 5 Rob Church 2006-11-04 14:36:44 UTC
I like the idea of a dismissable warning, as proposed by Brion, however.
Comment 6 Chad H. 2008-03-24 19:32:42 UTC
Created attachment 4756 [details]
Removes "Edit this page" if blocked.

The following patch will replace "Edit this page" with "View source" if the user is blocked. Not sure if this is how we want to proceed or not, just going on Rob's comment in #2.
Comment 7 Chad H. 2008-10-21 00:05:23 UTC
Patch applied in r42281
Comment 8 Chad H. 2008-10-21 00:27:05 UTC
Reverted in r42282, Splarka reminded me that this will break the static html cache :(
Comment 9 Peter Gervai (grin) 2008-10-21 08:57:51 UTC
That's why the original report was about registered users only.
I was thinking about playing tricks with css, but it'll break _some_ cache _somewhere_ anyway for anon users.
Comment 10 Platonides 2010-01-22 17:33:34 UTC
isBlocked() seems expensive to gratuitously call it on every view by registered users.
Why is it bad to wait until they hit edit?
Comment 11 Aaron Schulz 2011-03-18 11:48:07 UTC
(In reply to comment #10)
> isBlocked() seems expensive to gratuitously call it on every view by registered
> users.
> Why is it bad to wait until they hit edit?

I feel the same.
Comment 12 p858snake 2011-04-30 00:09:29 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 13 Sumana Harihareswara 2011-11-09 20:13:10 UTC
+reviewed per comment 8

Note You need to log in before you can comment on or make changes to this bug.