Last modified: 2011-08-05 21:33:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27025, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25025 - Add pre commit hook to prevent blank commit summaries
Add pre commit hook to prevent blank commit summaries
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Subversion (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Chad H.
: shell
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-09-02 19:08 UTC by Sam Reed (reedy)
Modified: 2011-08-05 21:33 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2010-09-02 19:08:18 UTC
As above
Comment 1 JeLuF 2010-09-08 05:59:58 UTC
On which wiki?
Has the community discussed and approved this?
Comment 2 p858snake 2010-09-08 06:01:03 UTC
(In reply to comment #1)
> On which wiki?
> Has the community discussed and approved this?
On SVN not wiki, silly!.
Comment 3 Chad H. 2010-09-08 10:36:27 UTC
I support this!

http://www.powertrip.co.za/blog/archives/pre-commit

Could work, tweaking the < 10 to be some value we'd like to set as minimum :)
Comment 4 Sam Reed (reedy) 2010-09-08 21:13:41 UTC
Certainly seems to make some sense.

I'm sure there are very few use cases that a summary would be < 10 chars.

Unless we all become avar... Then it'll be many times greater than this ;)
Comment 5 Chad H. 2010-09-08 22:32:18 UTC
"eol-style" and "typofix" are both less than 10, and both common commit summaries. I've also seen people do things like "b->a" to indicate a 1-letter change. I'd say as long as it's at least 3 characters or so we'd be fine. The main thing to rule out is empty commit summaries. 

(Of course this does nothing to help people make their commit summaries *descriptive* of their changes, but that's a social problem)
Comment 6 Chad H. 2010-09-09 00:47:08 UTC
Empty commit summaries are blocked now. Just used the example from pre-commit.tmpl :)
Comment 7 Sam Reed (reedy) 2011-07-27 22:35:29 UTC
Why hasn't this been reopened already? :P
Comment 8 Chad H. 2011-08-05 21:33:47 UTC
Fixed and re-deployed. See /trunk/tools/subversion/hooks.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links