Last modified: 2014-08-17 11:43:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T27009, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 25009 - img_auth.php should have "Expires: 0", "Pragma: cache" for IE and SSL
img_auth.php should have "Expires: 0", "Pragma: cache" for IE and SSL
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.15.x
All Linux
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
aklapper-moreinfo
: testme
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-09-01 09:51 UTC by Pål Hjelmeseth Myklebust
Modified: 2014-08-17 11:43 UTC (History)
6 users (show)

See Also:
Web browser: Internet Explorer
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Pål Hjelmeseth Myklebust 2010-09-01 09:51:59 UTC
When you try to download a file through img_auth.php in IE (works fine in both Firefox and Opera) on a host served over SSL you get an error.

I worked around the problem by changing the following line in img_auth.php:

wfStreamFile( $filename, array( 'Cache-Control: private', 'Vary: Cookie' ) );

to:

wfStreamFile( $filename, array("Expires: 0", "Cache-Control: private", "Pragma: cache"));
Comment 1 Mark Holmquist 2012-07-25 15:28:50 UTC
I'm not sure if this bug is still relevant, but if it is, would you care to get developer access [1] and submit a patch via Gerrit, our code review tool? It would be really great to get this fixed, as it's almost certainly something that affects multiple people.

If this is no longer a bug, either resolve it or reply here saying it can be resolved. Thanks!

[1] http://www.mediawiki.org/wiki/Developer_access
Comment 2 Andre Klapper 2012-12-05 14:16:47 UTC
Pål: Any place where one could test this?
Which IE version is this about? Which MediaWiki version nowadays?


The line in the source code nowadays (1.21) is:
// Stream the requested file
wfDebugLog( 'img_auth', "Streaming `".$filename."`." );
$repo->streamFile( $filename, array( 'Cache-Control: private', 'Vary: Cookie' ) );

I also found http://stackoverflow.com/questions/6491789/http-headers-controlling-cache-and-history-mechanism for some basic background info.
Comment 3 Bawolff (Brian Wolff) 2014-05-22 16:19:14 UTC
Umm, what is the error in question?
Comment 4 Andre Klapper 2014-08-17 11:43:01 UTC
Pål not answering; comment 1 to comment 3 unanswered.
Unfortunately closing this report as no further information has been provided.

Pål: Please feel free to reopen this report if you can provide the information asked for and if this still happens. Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links