Last modified: 2010-10-17 22:34:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26995, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24995 - "fallback" key missing from localization cache
"fallback" key missing from localization cache
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
1.17.x
All All
: Normal major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 25096 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-31 08:40 UTC by Daniel Kinzler
Modified: 2010-10-17 22:34 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Daniel Kinzler 2010-08-31 08:40:30 UTC
I have been getting this for weeks, and i'm still getting it with the latest trunk:

Notice: Undefined index:  fallback in /var/www/daniel/TestWiki-TIFF/phase3/includes/LocalisationCache.php on line 211:
  {main}(  ) called from ../index.php:0
  WebRequest->getVal(  ) called from ../index.php:56
  WebRequest->getGPCVal(  ) called from ../WebRequest.php:250
  StubContLang->checkTitleEncoding(  ) called from ../WebRequest.php:228
  StubContLang->__call(  ) called from ../StubObject.php:0
  StubObject->_call(  ) called from ../StubObject.php:121
  StubObject->_unstub(  ) called from ../StubObject.php:57
  StubContLang->_newObject(  ) called from ../StubObject.php:103
  Language::factory(  ) called from ../StubObject.php:126
  Language::newFromCode(  ) called from ../Language.php:140
  Language::getFallbackFor(  ) called from ../Language.php:169
  LocalisationCache->getItem(  ) called from ../Language.php:2803

So, the item "fallback" is missing from the localization cache. While poking at this, i found that:
* rebuilding the localization cache doesn't help
* it doesn't matter if i'm logged in, or what interface language I use
* I have the content language set to "de", didn't try another.
* If I touch localsettings, the warning is gone for *one* request, then re-appears

The last point leads me to the conclusion that something gets mangled during caching. When localsettings changes, the cache is discarded, and the (whatever) data is created afresh, and works fine. In the next request, it's pulled from the cache, but is found to be incomplete for some reason.

It's strange that this should only happen to me, though... any ideas?
Comment 1 Niklas Laxström 2010-08-31 09:05:26 UTC
Would be interesting to know if the $code passed to Language::getFallbackFor() is always the same.
Comment 2 Niklas Laxström 2010-08-31 14:02:45 UTC
Right, I must have missed this piece from the documentation:
 * @param $oldId Integer revision ID, null to fetch from request, zero for current

Seems a bit unsafe to have that as the default value.
Comment 3 Platonides 2010-08-31 14:05:25 UTC
Well, I also get that Notice... (content language = 'es')
Comment 4 Platonides 2010-09-08 12:56:28 UTC
*** Bug 25096 has been marked as a duplicate of this bug. ***
Comment 5 Platonides 2010-10-17 22:34:44 UTC
Fixed in r74932.

It was missing in the cache because it was called when it was already loading it.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links