Last modified: 2012-04-12 13:54:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26987, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 24987 - Special:ListUsers does not take external groups into account
Special:ListUsers does not take external groups into account
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.16.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-08-30 22:21 UTC by Mathias Ertl
Modified: 2012-04-12 13:54 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Proposed patch that fixes the problem (811 bytes, patch)
2010-08-30 22:21 UTC, Mathias Ertl 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Mathias Ertl 2010-08-30 22:21:08 UTC 
Created attachment 7661 [details]
Proposed patch that fixes the problem

The function formatRow in includes/specials/SpecialListusers.php gets and prints a list of groups the user is in. The function does not take into account that some groups might not show up in the database if they have been added using the UserEffectiveGroups hook. If the user is in no local groups or in just one local group, the groups from the external source are not shown. 

Attached is a proposed patch which fixes the problem. It also simplifies the code somewhat, I think there are some unnecessary checks there.
Comment 1 Roan Kattouw 2010-09-12 15:16:08 UTC 
Patch committed in r72864.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links