Last modified: 2012-04-14 19:39:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26981, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 24981 - Class SpecialUpload - no interface for manipulating upload summary/mComment
Class SpecialUpload - no interface for manipulating upload summary/mComment
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
1.16.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
: 25833 (view as bug list)
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-08-29 20:59 UTC by raZe
Modified: 2012-04-14 19:39 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description raZe 2010-08-29 20:59:01 UTC 
Since 1.16 many members of this class were set to scope "protected".

The description of hook UploadForm:BeforeProcessing says:"Called just before the file data (for example description) are processed, so extensions have a chance to manipulate them."

As I have not found any way to manipulate e.g. mComment I feel this is a bug to be addressed. 

(One of my extensions actively manipulated the comments till 1.15...)

Kind regards
raZe
Comment 1 Bryan Tong Minh 2010-08-29 21:33:32 UTC 
Assigning to me.

Easiest is probably to make the variables public again for backwardscompatibility.
Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2010-08-29 21:48:06 UTC 
r57868 was the problem.  It changed loads of fields to protected for no apparent reason.  Fixed in r71903, backported to the 1.16 branch in r71904, added forgotten RELEASE-NOTES in r71905.  So this should be part of 1.16.1 when that's released, as well as 1.17.  For now you can manually patch the file, since you know that the changes won't be overwritten when you upgrade.
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2010-08-29 21:48:17 UTC 
(mid-air collision, oh well :) )
Comment 4 Bryan Tong Minh 2010-11-08 07:50:21 UTC 
*** Bug 25833 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links