Last modified: 2014-02-23 19:26:05 UTC
Page histories have 2 buttons for comparing the selected revisions, but both have the same access key ("v" on mediawiki-org). This cause on Mozilla Firefox to altern focus between both buttons when using the access key instead of directly trigger one of the two buttons. Since both buttons have the same purpose, I propose to just remove the accesskey of one of them, so only the button at the top would have accesskey. That would fix the issue.
Fixed in r72424.
This is broken again (since r108372 I think).
Nowadays Alt+Shift+V (at least in Firefox) is used by three tools: * "Edit" in the top bar (via Visual Editor) * the "Compare selected versions" top button on &action=history * the "Compare selected versions" bottom button on &action=history While the technical fix might be easy, coming to an agreement which item should keep its access key might not. Hence removing keyword.
I think the problem with visual editor is a separate bug (Bug 52969). The problem with the duplicated accesskey in page histories will still be a bug even if either visual editor or page histories change to another accesskey. And it is also still a bug for anyone not using the Visual Editor extension. What is needed for this bug is that the accesskey is removed from either the top or the bottom compare buttons. There might be some few users who will disagree about choosing button which should have the accesskey, but I think they will only have minor problems getting used to only using the chosen button. Most users will just be happy that the bug is fixed.
