Last modified: 2014-08-01 08:12:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26972, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 24972 - Book editor panel must not use #siteNotice wrapper
Book editor panel must not use #siteNotice wrapper
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Collection (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-08-28 20:53 UTC by Danny B.
Modified: 2014-08-01 08:12 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Danny B. 2010-08-28 20:53:34 UTC 
Book editor panel must not use #siteNotice wrapper.

* It semantically does not belong there. #siteNotice is for site notices. Not for other things. Create new sibling after #siteNotice instead.
* Lot of people turn off all notices by using display:none for #siteNotice which disables the panel.
* Such wrapper has random styling on local wikis which may override default settings of the panel.
Comment 1 Johannes Beigel 2010-08-30 09:27:44 UTC 
We're actually using the hook SiteNoticeAfter to render that box, so the #siteNotice ID is inserted by core MediaWiki code. Any ideas what we could use instead?
Comment 2 Bugmeister Bot 2011-08-19 19:12:27 UTC 
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Comment 3 Roland Rosenfeld 2012-04-25 08:14:11 UTC 
This also causes trouble with http://www.mediawiki.org/wiki/Extension:DismissableSiteNotice
If both are enabled and the current SiteNotice was disabled per click, the book editor panel is completely missing.
Comment 4 Roland Rosenfeld 2012-04-25 14:10:09 UTC 
Including DismissableSiteNotice before Collection works around the problem for these both extensions, but doesn't solve the main problem.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links