Last modified: 2010-05-15 15:37:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T4496, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 2496 - MediaWiki:Edithelppage assumes internal url
MediaWiki:Edithelppage assumes internal url
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
PC Linux
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2005-06-23 20:51 UTC by Matt Conway
Modified: 2010-05-15 15:37 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Matt Conway 2005-06-23 20:51:27 UTC
I was unable to use an external url (i.e. for MediaWiki:edithelppage as it
was always generating an internal url on pageview.

Here is a patch that fixes this.

Index: includes/EditPage.php
RCS file: /cvsroot/wikipedia/phase3/includes/EditPage.php,v
retrieving revision 1.176
diff -u -r1.176 EditPage.php
--- includes/EditPage.php       1 Jun 2005 08:18:34 -0000       1.176
+++ includes/EditPage.php       23 Jun 2005 20:43:50 -0000
@@ -520,7 +520,7 @@

                $cancel = $sk->makeKnownLink( $this->mTitle->getPrefixedText(),
                                wfMsg('cancel') );
-               $edithelpurl = $sk->makeUrl( wfMsg( 'edithelppage' ));
+               $edithelpurl = $sk->makeInternalOrExternalUrl( wfMsg(
'edithelppage' ));
                $edithelp = '<a target="helpwindow" href="'.$edithelpurl.'">'.
                        htmlspecialchars( wfMsg( 'edithelp' ) ).'</a> '.
                        htmlspecialchars( wfMsg( 'newwindow' ) );
Comment 1 Brion Vibber 2005-06-23 20:53:24 UTC
Not sure what this means...? What's a case in which this fails, and what are the expected and 
actual results?
Comment 2 Matt Conway 2005-06-23 21:00:47 UTC
If I edit MediaWiki:edithelppage to be
"" instead of the default
"Help:Editing", and I go to edit a page, the url for the "Editing Help" link is
an internal one -

This patch lets either case work.
Comment 3 JeLuF 2005-06-25 21:32:41 UTC
Fixed in EditPage.php, rev 1.178

Note You need to log in before you can comment on or make changes to this bug.