Last modified: 2010-08-27 06:26:45 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26952, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24952 - Is the seperate Spyc include needed
Is the seperate Spyc include needed
Status: RESOLVED INVALID
Product: MediaWiki extensions
Classification: Unclassified
Translate (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Niklas Laxström
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-26 23:43 UTC by Sam Reed (reedy)
Modified: 2010-08-27 06:26 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2010-08-26 23:43:39 UTC
The Api had a version of it in ApiFormatYaml_spypc or something. Tim stripped out a lot of crap from it (security or something).

Noticed you optionally include it

00077     public static function dump( $text ) {
00078         global $wgTranslateYamlLibrary;
00079 
00080         switch ( $wgTranslateYamlLibrary ) {
00081             case 'spyc':
00082                 require_once( dirname( __FILE__ ) . '/../spyc/spyc.php' );
00083                 return Spyc::YAMLDump( $text );
00084             case 'syck':
00085                 return self::syckDump( $text );
00086             default:
00087                 throw new MWException( "Unknown Yaml library" );
00088         }
00089     }

Do you still need a seperate version?
Comment 1 Niklas Laxström 2010-08-27 06:26:45 UTC
The "lot of crap" happens to be the parsing of YAML files. The API version is very old, crippled to be unusable and has other unknown modifications (that probably never went to upstream. So yeah I can't and don't want to use it as it is now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links