Last modified: 2012-09-27 01:10:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26906, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24906 - Vector should use the common messages like other skins
Vector should use the common messages like other skins
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.16.x
All All
: Normal minor (vote)
: ---
Assigned To: Adam Miller
: i18n
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-22 23:59 UTC by Leinad
Modified: 2012-09-27 01:10 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Leinad 2010-08-22 23:59:11 UTC
Please merge Vector messages with common messages of other skins, for example:
* [[MediaWiki:Vector-namespace-main]] and [[MediaWiki:Nstab-main]]
* [[MediaWiki:Vector-view-history]] and [[MediaWiki:History short]]
etc.

It is a waste of time when need to locally modify messages for *all skins* and separately for Vector.
Comment 1 Trevor Parscal 2010-08-23 16:47:54 UTC
Message re-use is usually discouraged, and in the case of vector it makes sense, as the visual context and space constraints are unique to Vector, and should not be assumed to be the same as other skins.

The software on translatewiki.net is smart enough to be able to use the qqq messages that indicate the message is similar to another (when appropriate) so that it's not the same amount of effort to translate the second message once the first has been done. Often the difference is brevity or more strictly using verbs for the right-side tabs.
Comment 2 Leinad 2010-08-23 17:18:50 UTC
(In reply to comment #1)
> Message re-use is usually discouraged, and in the case of vector it makes
> sense, as the visual context and space constraints are unique to Vector, and
> should not be assumed to be the same as other skins.

Please, do not be lazy... Let's be practical, not bureaucratic. Wikimedia users not only use Vector, but also other skins.

What is the difference between:
* [[MediaWiki:Vector-namespace-main]] and [[MediaWiki:Nstab-main]]
* [[MediaWiki:vector-namespace-category]] and [[MediaWiki:Nstab-category]]
* [[MediaWiki:vector-namespace-help]] and [[MediaWiki:Nstab-help]]
* [[MediaWiki:vector-namespace-image]] and [[MediaWiki:Nstab-image]]
* [[MediaWiki:vector-namespace-media]] and [[MediaWiki:Nstab-media]]
* [[MediaWiki:vector-namespace-mediawiki]] and [[MediaWiki:Nstab-mediawiki]]
* [[MediaWiki:vector-namespace-project]] and [[MediaWiki:Nstab-project]]
* [[MediaWiki:vector-namespace-special]] and [[MediaWiki:Nstab-special]]
* [[MediaWiki:vector-namespace-template]] and [[MediaWiki:Nstab-template]]
* [[MediaWiki:vector-namespace-user]] and [[MediaWiki:Nstab-user]]
etc.
???

Answer: Nothing(!) Both messages will *alwyas* have the same text.

> The software on translatewiki.net is smart enough to be able to use the qqq
> messages that indicate the message is similar to another (when appropriate) so
> that it's not the same amount of effort to translate the second message once
> the first has been done. Often the difference is brevity or more strictly using
> verbs for the right-side tabs.

I said about modifying messages locally where admins do not know that exist extra messages for Vector. Admins of projects do not see qqq messages.
Comment 3 Platonides 2010-08-23 22:30:39 UTC
> the visual context and space constraints are unique to Vector, and
> should not be assumed to be the same as other skins.

That could be argued for all skins. "My skin is so special it needs an specific message".

I don't see such need for at least the provided examples. Of course, the ability of giving eg. a large name for vector, is neat, but that will bite us later when the two sets of tabs gets desynchronized.

We could get the best of both worlds by doing everywhere wfEmptyMsg('vector-namespace-main') ? wfMsg( 'nstab-main' ) : wfMsg('vector-namespace-main') but that looks ugly.
Comment 4 Leinad 2010-08-23 22:59:36 UTC
> later when the two sets of tabs gets desynchronized.

Exactly, for example on Meta we had desynchronized MediaWiki:Vector-namespace-main and MediaWiki:Nstab-main.
Comment 5 Leinad 2010-08-24 00:12:49 UTC
Before you start http://usability.wikimedia.org/wiki/Releases/Default_Switch#Phase_V_Deployment I would suggest you to fix this issue.

A lot of small projects not done translating Vector messages, but these projects have ready the same messages for other skins.

It is unwise to switch projects, which now have an interface in their mother tongue, and after switching a number of messages will be in English, because someone did not want to use the common messages.
Comment 6 Chad H. 2010-08-26 19:06:22 UTC
Not an enhancement, this is a bug. I've disagreed with this choice since the beginning (I complained somewhere...). 

(In reply to comment #3)
> > the visual context and space constraints are unique to Vector, and
> > should not be assumed to be the same as other skins.
> 
> That could be argued for all skins. "My skin is so special it needs an specific
> message".
> 

This. And no, skins aren't so special. Skins are designed to present a different visual look to a page. The elements of the page should retain their familiar names across all skins.

> I don't see such need for at least the provided examples. Of course, the
> ability of giving eg. a large name for vector, is neat, but that will bite us
> later when the two sets of tabs gets desynchronized.
> 

They can and they will. And we will inevitably get complaints that "When I changed nstab-whatever it didn't work in Vector"

> We could get the best of both worlds by doing everywhere
> wfEmptyMsg('vector-namespace-main') ? wfMsg( 'nstab-main' ) :
> wfMsg('vector-namespace-main') but that looks ugly.

Ugh. You *could* do that in Vector. Preferably we should just chunk the redundant messages entirely.
Comment 7 Roan Kattouw 2010-08-26 19:07:46 UTC
(In reply to comment #6)
> Ugh. You *could* do that in Vector. Preferably we should just chunk the
> redundant messages entirely.
That's what we're doing, yes. Adam has been assigned to eliminate this duplication for the namespace tabs (not for the action tabs (read, edit, history, ...) because it at least somewhat makes sense there).
Comment 8 Chad H. 2010-08-26 23:27:20 UTC
(In reply to comment #7)
> That's what we're doing, yes. Adam has been assigned to eliminate this
> duplication for the namespace tabs 

Yay :)

> (not for the action tabs (read, edit,
> history, ...) because it at least somewhat makes sense there).

I disagree :(
Comment 9 Daniel Friesen 2011-01-14 00:18:49 UTC
In 1.18 the new content_navigation code now supports things like "{skinname}-action-delete" falling back to generic messages like "delete" when the skin specific message does not exist. A new wfMessageFallback abstracts it a bit.
Comment 10 Siebrand Mazeland 2011-09-03 16:48:56 UTC
This was done in r72055. 12 Vector specific messages remain at the moment, but those have a valid reason, IMO.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links