Last modified: 2010-08-27 23:39:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26840, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 24840 - CR should give some sort of error messages when revision can't be found
CR should give some sort of error messages when revision can't be found
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2010-08-18 02:45 UTC by p858snake
Modified: 2010-08-27 23:39 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description p858snake 2010-08-18 02:45:57 UTC 
When a revision can't be found[1], Code Review just dumps you back into the path folder showing the table review which can be confusing and should offer some sort of message explaining that the revision can't be found.


[1]. http://www.mediawiki.org/wiki/Special:Code/MediaWiki/cheese [2]
[2]. Which is impossible to happen due to revisions needing to be numbers, but if i used a number, Its possible that it can be done so this is only for demo purposes.
Comment 1 Sam Reed (reedy) 2010-08-18 07:38:36 UTC 
		if ( !$this->mRev ) {
			$view = new CodeRevisionListView( $this->mRepo->getName() );
			$view->execute();
			return;
		}
Comment 2 Sam Reed (reedy) 2010-08-18 07:41:15 UTC 
Could just poke in the following code into the if
'code-rev-not-found' => 'Revision<b>$1</b> does not exist!',

display it, and then do the fallback to the code revision list view?
Comment 3 Sam Reed (reedy) 2010-08-27 23:39:17 UTC 
r71825
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links