Last modified: 2014-11-17 09:21:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26821, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24821 - ImageMagick identify uses a lot of memory
ImageMagick identify uses a lot of memory
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
PagedTiffHandler (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Markus Glaser
: patch-need-review
Depends on:
Blocks: 23258
  Show dependency treegraph
 
Reported: 2010-08-17 03:07 UTC by Tim Starling
Modified: 2014-11-17 09:21 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tim Starling 2010-08-17 03:07:39 UTC
PagedTiffHandler uses ImageMagick identify to get some information about the file, such as the widths and heights of each of the pages. It appears to be extremely memory-inefficient, probably decompressing the whole image. This will cause images to fail to be rescaled, or to fail to upload, once PagedTiffHandler is deployed. 

Please consider tiffinfo from libtiff as an alternative.
Comment 1 Daniel Kinzler 2010-08-17 07:26:12 UTC
I understand the issue, and I'll llook into libtiff for this. However, using identify has one very important advantage: it will fail just in the cases where convert/mogrify will fail. That is, it's a pretty good way to determine which tiff files can actually be rendered, and which can't.
Comment 2 Tim Starling 2010-08-17 08:05:50 UTC
Actually it won't. We use a different shell memory limit on the image scalers compared to the main cluster.
Comment 3 Daniel Kinzler 2010-08-17 08:11:26 UTC
I wasn't talking about failure because of memory limits, but because of unsupported variants of tiff - codecs, etc. there's quite a few of those, check out http://www.libtiff.org/images.html
Comment 4 Daniel Kinzler 2010-08-17 15:17:04 UTC
I added support for libtiff/tiffinfo in r71204, please have a look
Comment 5 Daniel Kinzler 2010-09-03 09:34:53 UTC
marking as fixed, since libtiff/tiffinfo is now used live. Issues with tiffinfo are being tracked by bug 24984.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links