Last modified: 2012-11-18 22:49:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26778, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24778 - abbr element broken in IE 6
abbr element broken in IE 6
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Krinkle
aklapper-moreinfo
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-13 10:49 UTC by entlinkt
Modified: 2012-11-18 22:49 UTC (History)
5 users (show)

See Also:
Web browser: Internet Explorer
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed fix (523 bytes, patch)
2010-09-07 19:54 UTC, entlinkt
Details
Testcase (731 bytes, text/html)
2010-09-07 22:56 UTC, entlinkt
Details

Description entlinkt 2010-08-13 10:49:45 UTC
The abbr element (used in MediaWiki since r54241 and r54242) cannot be styled in IE 6 because IE 6 does not know about it and therefore treats it like all unknown tags: It adds two void elements to the DOM, one with the tag name "abbr" and another one with the tag name "/abbr" (sic).

This can be fixed using the technique described at http://intertwingly.net/blog/2008/01/22/Best-Standards-Support#c1201006277, possibly inside a conditional comment and only for IE 6; IE >= 7 supports the abbr element natively.
Comment 1 entlinkt 2010-09-07 19:54:07 UTC
Created attachment 7674 [details]
Proposed fix

This should fix it. I also had to change wikibits.js because the check for ie6_bugs was broken since r65774.
Comment 2 entlinkt 2010-09-07 22:56:49 UTC
Created attachment 7677 [details]
Testcase

Please note that this hack works only if it is executed before any unknown elements (see testcase). Is that still the case with ResourceLoader? r72349 is unclear to me ("all JS is now loaded at the bottom" - bottom of what?).
Comment 3 entlinkt 2010-09-14 02:07:02 UTC
Comment on attachment 7674 [details]
Proposed fix

"At the bottom" apparently means "immediately before the closing </body> tag. That is too late, IE has already misparsed everything at that point.

Reported Bug 25167 about the ie6_bugs breakage.
Comment 4 p858snake 2011-04-30 00:10:06 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 5 Krinkle 2011-06-06 17:07:45 UTC
(In reply to comment #3)
> 
> "At the bottom" apparently means "immediately before the closing </body> tag.
> That is too late, IE has already misparsed everything at that point.
> 

That's right. However as of ResourceLoader 2 there is a "position" property available in the module registry. Those registered as "top" will be loaded in the <head>.

We could either turn this property in the IEFixes-module or create a seperate module for "top" things. Given the small size of the module, I think we can just swap this module to the top and add the abbr-creation fix to it.
Comment 6 Krinkle 2011-06-06 17:09:06 UTC
Hm.. it's not loaded as a module, it's loaded from wikibits.js (which is loaded from the bottom)...
Comment 7 Krinkle 2011-07-28 00:07:10 UTC
1.17 has passed, moving to 2.0
Comment 8 Sumana Harihareswara 2011-11-09 20:12:19 UTC
Removed the "patch" keyword since there's no longer a patch here to review.

entlinkt@gmx-topmail.de, can you still reproduce this issue?
Comment 9 Andre Klapper 2012-09-20 13:55:11 UTC
entlinkt@, do you still see this problem?
Comment 10 Antoine "hashar" Musso (WMF) 2012-11-18 14:11:31 UTC
I would simply wontfix that bug. It is a really minor issue and only affect IE6 which is quiet a old browser. According to our compatibility chart at http://www.mediawiki.org/wiki/Compatibility#Browser IE6 is no more eligible to get everything fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links