Last modified: 2012-05-04 22:37:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26753, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24753 - Callback actions are run when the toolbar is loaded, not when the tool button is clicked
Callback actions are run when the toolbar is loaded, not when the tool button...
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
unspecified
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-11 07:40 UTC by Huji
Modified: 2012-05-04 22:37 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Huji 2010-08-11 07:40:01 UTC
In order for the WikiEditor toolbar to be extensible, we need a way to allow addition of toolbar buttons which execute custom functions when clicked. The 'callback' action seems to be created to address this issue. However, when you create a custom button with 'callback' action and pass the callback function name using the 'execute' property, this function is called when the toolbar is loaded (that is, right after the edit page is loaded).

Expected result would be not to execute the function on page load, but to only execute it when the specific button is clicked on.
Comment 1 Roan Kattouw 2010-08-11 08:57:40 UTC
I think the idea is to use the callback to bind event handlers and do other manipulation.
Comment 2 Huji 2010-08-11 09:10:47 UTC
If that's the case, then I'd like to propose an enhancement allowing calling custom functions for button clicks directly through action{} object.
Comment 3 Bugmeister Bot 2011-08-19 19:12:54 UTC
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links