Last modified: 2012-07-24 11:24:40 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26631, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24631 - MediaWiki:Pagetitle-view-mainpage has no effect on main page
MediaWiki:Pagetitle-view-mainpage has no effect on main page
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.16.x
PC Linux
: Low enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-08-02 12:28 UTC by Anton Yackushev
Modified: 2012-07-24 11:24 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Anton Yackushev 2010-08-02 12:28:41 UTC
The "Pagetitle-view-mainpage" is defined as "example", however the
<title> element is not currently displaying this content. Instead, it displays
the default "Main Page - SITENAME" content.
Comment 1 Anton Yackushev 2010-08-02 15:29:37 UTC
Tried on the version from a trunk, in different languages - the effect is not present.
Comment 2 Roan Kattouw 2010-08-04 11:03:48 UTC
Have you tried making a null edit (i.e. an edit without changes) to the page?
Comment 3 Anton Yackushev 2010-08-04 11:28:22 UTC
(In reply to comment #2)
> Have you tried making a null edit (i.e. an edit without changes) to the page?

I do not quite understand.
Comment 4 X! 2010-08-04 11:36:35 UTC
Follow the instructions at [[WP:NULL]] to make a null edit. Basically, you're saving a page without making any changes.
Comment 5 Anton Yackushev 2010-08-04 12:07:57 UTC
Yes, I made a null edit + cleared the cache. It did not help
Comment 6 Anton Yackushev 2010-08-06 17:38:35 UTC
I can I tell nonsense, but it is more to me comes to than nothing mind: there can be it because of a used database? At me PostgreSQL 8.4.4. Unfortunately to put MySQL for the test at present I can not.
Comment 7 Nanda Jansen 2010-09-22 12:45:03 UTC
Have the same problem. Also since Mediawiki 1.16.0.
Comment 8 Pascal 2010-10-24 11:32:15 UTC
(In reply to comment #6)
> I can I tell nonsense, but it is more to me comes to than nothing mind: there
> can be it because of a used database? At me PostgreSQL 8.4.4. Unfortunately to
> put MySQL for the test at present I can not.

I have the same problem since updating to 1.16.0 - I use MySQL 4.1.22 and PHP 5.2.12, so it is not because of using PostgreSQL.
Comment 9 MZMcBride 2010-11-11 20:55:58 UTC
I'm rather convinced that this is a regression in the 1.16.0 branch. Is there a keyword to tag this bug?
Comment 10 Max Semenik 2010-11-11 21:07:10 UTC
Fixed on trunk with r64876. We can backport changes related to setHTMLTitle() from it.
Comment 11 Anton Yackushev 2011-01-11 17:47:34 UTC
(In reply to comment #10)
> Fixed on trunk with r64876. We can backport changes related to setHTMLTitle()
> from it.


Has helped but only if to change this code location:

@@ -447,17 +447,9 @@
 	/**
 	 * "HTML title" means the contents of <title>.
 	 * It is stored as plain, unescaped text and will be run through htmlspecialchars in the skin file.
-	 * If $name is from page title, it can only override names which are also from page title,
-	 * but if it is not from page title, it can override all other names.
 	 */
-	public function setHTMLTitle( $name, $frompagetitle = false ) {
-		if ( $frompagetitle && $this->mHTMLtitleFromPagetitle ) {
-			$this->mHTMLtitle = $name;
-		}
-		elseif ( $this->mHTMLtitleFromPagetitle ) {
-			$this->mHTMLtitle = $name;
-			$this->mHTMLtitleFromPagetitle = false;
-		}
+	public function setHTMLTitle( $name ) {
+		$this->mHTMLtitle = $name;
 	}

If you change all file OutPage.php, I receive an error:

PHP Fatal error:  Call to undefined method OutputPage::getFrameOptions() in /var/www/.../includes/Skin.php on line 416
Comment 12 MZMcBride 2011-01-12 18:47:28 UTC
This isn't fixed. The changes still need to be backported.
Comment 13 Nemo 2012-07-24 11:24:40 UTC
1.16 no longer supported.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links