Last modified: 2013-08-31 14:50:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26528, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 24528 - Dialogs broken when mwEmbed is enabled


Summary:	Dialogs broken when mwEmbed is enabled

Status:	RESOLVED WONTFIX

Product:	MediaWiki extensions
Classification:	Unclassified
Component:	UsabilityInitiative (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Low critical with 1 vote (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-07-24 15:44 UTC by Derk-Jan Hartman
Modified:	2013-08-31 14:50 UTC (History)
CC List:	6 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Screenshot of issue. (152.83 KB, image/png) 2010-07-27 00:50 UTC, Monomium	Details
Add an attachment (proposed patch, testcase, etc.)

Description Derk-Jan Hartman 2010-07-24 15:44:07 UTC

Using the dialogs on current wikipedia installations results in the following error (Search and replace and insert link):

TypeError: Result of expression '$('<div />').attr('id',module.id).html(module.html).data('context',context).appendTo($('body')).each(module.init).dialog' [undefined] is not a function.

Occurs with Safari 5, Chrome, and Opera 10 on Mac OS X Snow Leopard, but works on FF4.

Comment 1 Adam Miller 2010-07-26 20:01:46 UTC

Here's what I was able to figure out so far: 

Only occurs when both Twinkle and mwEmbed gadgets are enabled. Once they are enabled, it seems like jquery ui is not loaded on the edit page.

Comment 2 Adam Miller 2010-07-26 20:02:31 UTC

Related screenshot is here: http://en.wikipedia.org/wiki/File:Dialogs_not_working.png

Comment 3 Monomium 2010-07-27 00:49:14 UTC

I disabled mwembed, working now without that, so you know...

Comment 4 Monomium 2010-07-27 00:50:57 UTC

Created attachment 7595 [details]
Screenshot of issue.

Comment 5 Derk-Jan Hartman 2010-10-18 09:43:20 UTC

This is fixed now for me. mwEmbed + Twinkle + dialogs seems to work.

Comment 6 Monomium 2010-10-27 03:26:01 UTC

Not fixed for me...

Comment 7 Bugmeister Bot 2011-08-19 19:12:53 UTC

Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734

Comment 8 Nemo 2012-11-06 09:06:14 UTC

Michael, can such mwEmbed bug be closed (isn't it superseded?)?

Comment 9 Michael Dale 2012-11-06 16:54:58 UTC

We should disable the mwEmbed gadget now that Timed media handler is being enabled.

Comment 10 Nemo 2012-11-06 17:21:28 UTC

(In reply to comment #9)
> We should disable the mwEmbed gadget now that Timed media handler is being
> enabled.

Can you please do so on en.wiki, Commons and any other wiki using it by disabling/blanking it then? (You have global editinterface rights.)

Comment 11 Derk-Jan Hartman 2012-11-06 18:19:42 UTC

I had already removed it from en.wp and commons a while ago. Not sure if it is used anywhere else.

Comment 12 Andre Klapper 2013-08-31 14:50:25 UTC

WONTFIXing as we slowly get rid of mwEmbed anyway. 
Plus no clear steps to reproduce nowadays...

Note You need to log in before you can comment on or make changes to this bug.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links