Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26517, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 24517 - Usage of $this in static methods

Summary:	Usage of $this in static methods

Status: RESOLVED FIXED Product: MediaWiki Classification: Unclassified Component: File management (Other open bugs) Version: unspecified Hardware: All All Importance: Normal normal (vote) Target Milestone: --- Assigned To: Nobody - You can work on this! URL: Whiteboard: Keywords: Depends on: Blocks:   Show dependency tree / graph		Reported: 2010-07-23 20:05 UTC by Sam Reed (reedy) Modified: 2010-07-25 11:41 UTC (History) CC List: 4 users (show) Bryan.TongMinh gpaumier innocentkiller wikibugs See Also: Web browser: --- Mobile Platform: --- Assignee Huggle Beta Tester: ---

Attachments Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2010-07-23 20:05:48 UTC LocalFile.php and OldLocalFile.php In newFromKey() in both of the files, they have 2 uses of $this Comment 1 Sam Reed (reedy) 2010-07-24 19:05:22 UTC Also, while you're there.. $row = $dbr->selectRow( 'oldimage', $this->getCacheFields( 'oi_' ), $conds, $fname ); in newFromKey in OldLocalFile.php - $dbr is undefined Comment 2 Alexandre Emsenhuber [IAlex] 2010-07-25 11:41:23 UTC Fixed in r69869.