Last modified: 2012-04-12 13:56:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26496, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24496 - UniversalEditButton
UniversalEditButton
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Installer (Other open bugs)
1.16.x
All All
: Normal enhancement with 2 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-07-22 13:30 UTC by [[kgh]]
Modified: 2012-04-12 13:56 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description [[kgh]] 2010-07-22 13:30:16 UTC
So far an wiki administrator has to insert $wgUniversalEditButton = true; into LocalSettings.php in order to activate the Universal Edit Button for browsers that support it. I think it would be good if an wiki administrator gets asked during the installing process, if it should be activated or not.
Comment 1 Chad H. 2010-07-22 17:28:58 UTC
Maybe in 1.18. Not trying to add any more features to the new installer for 1.17.
Comment 2 MarkDilley 2010-07-22 18:44:26 UTC
My impression, which could be wrong, is that this was a standard on all Medawiki - so set to true would be the default.

Hope that is what is settled on :-)
Comment 3 [[kgh]] 2010-07-22 23:28:45 UTC
As I observed the UEB is indeed already standard on all MediaWiki installations of Wikimedia. This bug is aiming on increasing the awareness of this feature for new wikis and making it as easy as possible to implement it there.

(In reply to comment #2)
> My impression, which could be wrong, is that this was a standard on all
> Medawiki - so set to true would be the default.
> 
> Hope that is what is settled on :-)
Comment 4 MarkDilley 2010-07-23 00:49:11 UTC
:-)

As I recall - it was supposed to be standard on all MediaWiki - out the box.  I may have misunderstood what Brion told me though.

I like the idea of point blank asking an installer of the software because - you are right, it will help increase awareness!

:-)
Comment 5 Bawolff (Brian Wolff) 2010-07-23 06:28:32 UTC
$wgUniversalEditButton is set to true in DefaultSettings.php, so its always enabled unless the site admin explicitly disables it. Getting the installer to ask about every single configuration variable seems like a bad idea, as there are a lot, and many of them (like this one) 99% of people would not want to change.
Comment 6 [[kgh]] 2010-07-23 08:59:45 UTC
Ups, most probably I mistyped the search query while looking for it in DefaultSettings.php Since this is the case, I agree with you that asking for it during installation is not a good idea. Thank you for solving this!

(In reply to comment #5)
> $wgUniversalEditButton is set to true in DefaultSettings.php, so its always
> enabled unless the site admin explicitly disables it. Getting the installer to
> ask about every single configuration variable seems like a bad idea, as there
> are a lot, and many of them (like this one) 99% of people would not want to
> change.
Comment 7 p858snake 2010-07-23 09:05:58 UTC
(In reply to comment #6)
> Ups, most probably I mistyped the search query while looking for it in
> DefaultSettings.php Since this is the case, I agree with you that asking for it
> during installation is not a good idea. Thank you for solving this!
Can confirm its there, Line 3968. 
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/DefaultSettings.php?view=markup#l3967

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links