Last modified: 2013-06-18 15:18:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26491, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24491 - Users shouldn't be given "Upload a new version of this file" when a file is protected
Users shouldn't be given "Upload a new version of this file" when a file is p...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-07-22 11:10 UTC by Liangent
Modified: 2013-06-18 15:18 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Liangent 2010-07-22 11:10:01 UTC
Or they may spend some time on editing these files only to find their better images can only stay in their hard disk.
Comment 1 Derk-Jan Hartman 2010-07-22 16:02:30 UTC
Though in principal I agree, hiding elements in general causes confusion... "where did this option go". 

Adding guillom to CC, since he might have an opinion on this from the Multimedia usability project side.
Comment 2 Guillaume Paumier 2010-07-22 20:14:50 UTC
Derk-Jan is right, hiding it completely from the description page of a protected image would probably be confusing. I do understand Liangent's rationale though. 

A simple fix could be to replace the link for protected images by a message saying the file is protected, and linking to the upload page *without* prefilling the destination name (that way, the file won't be replaced). It would add clutter to the page, but we have plans to revamp it in the medium term anyway.
Comment 3 Bryan Tong Minh 2010-10-24 14:20:59 UTC
I would just not link to the upload page at all and replace the message by "You need to be an XY to be able to upload a new version of this file".
Comment 4 Bryan Tong Minh 2010-10-24 14:41:55 UTC
On the other hand, we don't show the link for users are not allowed to reupload at all.
Comment 5 MZMcBride 2012-08-09 19:25:41 UTC
I'm kind of shocked that this bug is still unresolved. This is a pretty awful user experience situation currently. Not only do we offer a "Upload a new version of this file" link on the file description page of a protected file, the upload form is completely unaffected by the file's protection. An unprivileged user will be shown a seemingly working file upload form and only after filling out and submitting the form does the user learn that the file is protected from re-uploads.

This should be a trivial fix. Marking this bug as "easy" and shifting around some of its classification.
Comment 6 Alex Monk 2012-08-13 20:19:01 UTC
Gerrit change #19379
Comment 7 Roan Kattouw 2012-08-22 02:10:34 UTC
(In reply to comment #6)
> Gerrit change #19379
Merged

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links