Last modified: 2014-05-20 10:40:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26489, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24489 - Remove the "Indentation" button from edit toolbar
Remove the "Indentation" button from edit toolbar
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Tina Johnson ( tinaj1234 )
: easy, javascript
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-07-22 10:11 UTC by Danny B.
Modified: 2014-05-20 10:40 UTC (History)
8 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Removed indentation button from WikiEditor toolbar. (2.85 KB, patch)
2013-11-09 14:10 UTC, Tina Johnson ( tinaj1234 )
Details

Description Danny B. 2010-07-22 10:11:26 UTC
Since there is no wikitext markup for indentation, but <dd> of <dl> is being hugely abused instead (see bug 4521), the "Indentation" button - which does not insert indentation but definition - should be removed from edit toolbar until proper solution for indentation is implemented.
Comment 1 Krinkle 2011-06-22 00:29:53 UTC
*Mass-change: Move WikiEditor bugs to component and remove blocker bug where*
Comment 2 Bugmeister Bot 2011-08-19 19:12:53 UTC
Unassigning default assignments. http://article.gmane.org/gmane.science.linguistics.wikipedia.technical/54734
Comment 3 Tina Johnson ( tinaj1234 ) 2013-11-05 07:25:40 UTC
Shall I remove the button and submit a patch?
Comment 4 Tina Johnson ( tinaj1234 ) 2013-11-05 10:36:45 UTC
The patch is submitted-https://gerrit.wikimedia.org/r/#/c/93665/
Comment 5 Gerrit Notification Bot 2013-11-05 10:46:44 UTC
Change 93665 had a related patch set uploaded by 01tonythomas:
Removed the indentation button from the WikiEditor toolbar.

https://gerrit.wikimedia.org/r/93665
Comment 6 Gerrit Notification Bot 2013-11-09 14:00:51 UTC
Change 94500 had a related patch set uploaded by Tinaj1234:
Removed indentation button from WikiEditor toolbar.

https://gerrit.wikimedia.org/r/94500
Comment 7 Tina Johnson ( tinaj1234 ) 2013-11-09 14:10:09 UTC
Created attachment 13752 [details]
Removed indentation button from WikiEditor toolbar.
Comment 8 Andre Klapper 2013-11-09 17:48:04 UTC
No need to duplicate patches to Bugzilla if they are in Gerrit already. :)
Comment 9 Gerrit Notification Bot 2013-12-17 10:17:50 UTC
Change 102101 had a related patch set uploaded by Tinaj1234:
Removed indentation button from WikiEditor extension

https://gerrit.wikimedia.org/r/102101
Comment 10 Gerrit Notification Bot 2013-12-18 05:13:19 UTC
Change 102101 abandoned by Tinaj1234:
Removed indentation button from WikiEditor extension

Reason:
This change previously exists. A patch was submitted earlier.
https://gerrit.wikimedia.org/r/#/c/94500/

https://gerrit.wikimedia.org/r/102101
Comment 11 Gerrit Notification Bot 2013-12-18 05:22:58 UTC
Change 93665 abandoned by Tinaj1234:
Removed the indentation button from the WikiEditor toolbar.

Reason:
A patch with all required changes exists.
https://gerrit.wikimedia.org/r/#/c/94500/

https://gerrit.wikimedia.org/r/93665
Comment 12 Gerrit Notification Bot 2014-03-12 12:04:41 UTC
Change 94500 merged by jenkins-bot:
Removed indentation button from WikiEditor toolbar.

https://gerrit.wikimedia.org/r/94500
Comment 13 Andre Klapper 2014-05-20 10:40:21 UTC
Assuming this bug is FIXED as all patches were merged (or abandoned).
If that is not the case: Please reopen and elaborate what is left to do here to get this report fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links