Last modified: 2010-07-21 19:58:52 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T26468, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 24468 - Invalid repo ID in CodeRevision::newFromRow
Invalid repo ID in CodeRevision::newFromRow
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
CodeReview (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-07-21 07:49 UTC by Sam Reed (reedy)
Modified: 2010-07-21 19:58 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Sam Reed (reedy) 2010-07-21 07:49:52 UTC
Invalid repo ID in CodeRevision::newFromRow
Backtrace:
#0 /home/reedy/mediawiki/trunk/extensions/CodeReview/ui/CodeRevisionListView.php(75): CodeRevision::newFromRow(Object(CodeRepository), Object(stdClass))
#1 /home/reedy/mediawiki/trunk/extensions/CodeReview/ui/CodeRevisionListView.php(29): CodeRevisionListView->doBatchChange()
#2 /home/reedy/mediawiki/trunk/extensions/CodeReview/ui/SpecialCode.php(102): CodeRevisionListView->execute()
#3 /home/reedy/mediawiki/trunk/phase3/includes/SpecialPage.php(581): SpecialCode->execute('autowikibrowser')
#4 /home/reedy/mediawiki/trunk/phase3/includes/Wiki.php(260): SpecialPage::executePath(Object(Title))
#5 /home/reedy/mediawiki/trunk/phase3/includes/Wiki.php(67): MediaWiki->handleSpecialCases(Object(Title), Object(OutputPage), Object(WebRequest))
#6 /home/reedy/mediawiki/trunk/phase3/index.php(116): MediaWiki->performRequestForTitle(Object(Title), NULL, Object(OutputPage), Object(User), Object(WebRequest))
#7 {main}

While trying to set a status on my current dev install. I have 2 code review things setup (MediaWiki and AutoWikiBrowser)
Comment 1 Sam Reed (reedy) 2010-07-21 07:51:15 UTC
I'll probably poke this later if I get chance, also drop both repo's etc, and see if that "fixes" it
Comment 2 Sam Reed (reedy) 2010-07-21 08:10:32 UTC
Was trying to look at the query speed of bug 24455 but hindered as couldn't set statuses via the gui


mysql> select COUNT(*), repo_name, cr_status FROM mw_code_rev cr, mw_code_repo cp WHERE cr_repo_id = repo_id GROUP BY cr_repo_id, cr_status;
+----------+-----------------+-----------+
| COUNT(*) | repo_name       | cr_status |
+----------+-----------------+-----------+
|     6802 | autowikibrowser | new       |
|    69657 | MediaWiki       | new       |
+----------+-----------------+-----------+
2 rows in set (0.00 sec)

(but that's presumably cached after doing a couple of other queries)
Comment 3 Sam Reed (reedy) 2010-07-21 19:16:22 UTC
^bah. Wrong bug
Comment 4 Sam Reed (reedy) 2010-07-21 19:58:52 UTC
r69704

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links